This is an archive of the discontinued LLVM Phabricator instance.

Fix thumb symbol value fixup in ObjectFileELF
ClosedPublic

Authored by sas on Apr 20 2015, 12:41 PM.

Reviewers

Commits

Summary

This is a cross-port of r235098 by Tamas Berghammer <tberghammer@google.com>.

This patch fixes a critical bug in thumb symbol handling on ARM platforms.

sas retitled this revision from to Fix thumb symbol value fixup in ObjectFileELF.

sas updated this object.

sas added a subscriber: Unknown Object (MLST).

clayborg edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2015, 1:53 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Plugins/

ObjectFile/

ELF/

2 lines

Show First 20 Lines • Show All 1,884 Lines • ▼ Show 20 Lines	for (i = 0; i < num_symbols; ++i)
symbol_section_sp = section_sp;		symbol_section_sp = section_sp;
}		}
}		}
}		}
}		}

// symbol_value_offset may contain 0 for ARM symbols or -1 for		// symbol_value_offset may contain 0 for ARM symbols or -1 for
// THUMB symbols. See above for more details.		// THUMB symbols. See above for more details.
uint64_t symbol_value = symbol.st_value \| symbol_value_offset;		uint64_t symbol_value = symbol.st_value + symbol_value_offset;
if (symbol_section_sp && CalculateType() != ObjectFile::Type::eTypeObjectFile)		if (symbol_section_sp && CalculateType() != ObjectFile::Type::eTypeObjectFile)
symbol_value -= symbol_section_sp->GetFileAddress();		symbol_value -= symbol_section_sp->GetFileAddress();
bool is_global = symbol.getBinding() == STB_GLOBAL;		bool is_global = symbol.getBinding() == STB_GLOBAL;
uint32_t flags = symbol.st_other << 8 \| symbol.st_info \| additional_flags;		uint32_t flags = symbol.st_other << 8 \| symbol.st_info \| additional_flags;
bool is_mangled = symbol_name ? (symbol_name[0] == '_' && symbol_name[1] == 'Z') : false;		bool is_mangled = symbol_name ? (symbol_name[0] == '_' && symbol_name[1] == 'Z') : false;

Symbol dc_symbol(		Symbol dc_symbol(
i + start_id, // ID is the original symbol table index.		i + start_id, // ID is the original symbol table index.
▲ Show 20 Lines • Show All 951 Lines • Show Last 20 Lines