This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

Authored by kastiglione on Nov 10 2020, 2:00 PM.



Following discussion in D91193, a change made in D88792 was not quite right.
This restores the message argument, and switches from expect to runCmd.

Diff Detail

Event Timeline

kastiglione created this revision.Nov 10 2020, 2:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 2:00 PM
kastiglione requested review of this revision.Nov 10 2020, 2:00 PM
teemperor accepted this revision.Nov 11 2020, 2:00 AM

I don't think we should re-add the bogus RUN_SUCCEEDED messages here. self.runCmd("print tpi") is undocumented, but still better than wrong documentation. Beside that this LGTM, thanks!

This revision is now accepted and ready to land.Nov 11 2020, 2:00 AM

Remove bogus message.

kastiglione marked 2 inline comments as done.Nov 11 2020, 10:07 AM