This is an archive of the discontinued LLVM Phabricator instance.

Fix signle stepping on arm when multiple thread is involved
ClosedPublic

Authored by tberghammer on Apr 20 2015, 6:33 AM.

Details

Summary

Fix single stepping on arm when multiple thread is involved

On linux-arm we use software single stepping where setting the new
breakpoint is only possible while the process is in stopped state.
This CL moves the setup code for single stepping form the SingleStep
operation into the Resume method to avoid an error when the process
already started when we want to step one of the thread.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Fix signle stepping on arm when multiple thread is involved.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added reviewers: sas, clayborg, omjavaid.
tberghammer added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Apr 20 2015, 9:36 AM
clayborg edited edge metadata.

Looks fine.

This revision is now accepted and ready to land.Apr 20 2015, 9:36 AM
sas accepted this revision.Apr 20 2015, 12:33 PM
sas edited edge metadata.
omjavaid accepted this revision.Apr 20 2015, 1:43 PM
omjavaid edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.