Page MenuHomePhabricator

[lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes
ClosedPublic

Authored by mgorny on Nov 9 2020, 6:45 AM.

Details

Summary

Fix DS/ES/FS/GS register sizes in getter/setter for FreeBSD. Apparently
only CS and SS registers are specified as 64/32-bit in LLDB, while
the others are specified as 16-bit. This fixes the failing
StandardStartupTest.TestStopReplyContainsThreadPcs lldb-server unittest.

Diff Detail

Event Timeline

mgorny created this revision.Nov 9 2020, 6:45 AM
mgorny requested review of this revision.Nov 9 2020, 6:45 AM
mgorny added a comment.Nov 9 2020, 6:50 AM

@labath, yes, I'm convinced already that we need to abstract this away into something more fancy like Linux does.

emaste accepted this revision.Nov 9 2020, 7:56 AM

Agree that even if refactoring is needed correcting these makes sense.

This revision is now accepted and ready to land.Nov 9 2020, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 5:18 AM