Replace the plethora of ObjC-implied 'skipUnlessDarwin' decorators
with marking tests as 'objc' category (whenever missing), and skip all
ObjC tests on non-Darwin platforms. I have used '.categories' file
wherever it was present already or all (>1) tests were relying on ObjC,
and explicit add_test_categories() where there was only one test.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCExpr.py | ||
|---|---|---|
| 17 | (this whole category has objc in .categories) | |
| lldb/test/API/functionalities/tsan/multiple/TestTsanMultiple.py | ||
| 16 | This one's curious. I'm wondering why it's explicitly marked for all the platforms while it.s clearly a .m file ;-). | |
| lldb/test/API/lang/objc/bitfield_ivars/TestBitfieldIvars.py | ||
| 11 | ditto | |
LGTM. Thanks for cleaning this up, it's really appreciated!
| lldb/packages/Python/lldbsuite/test/dotest.py | ||
|---|---|---|
| 839 | nit: we do from lldbsuite.test import lldbplatformutil in the surrounding code, so that seems more consistent. | |
| lldb/test/API/functionalities/tsan/multiple/TestTsanMultiple.py | ||
| 16 | For the record: I think those XFails were just copied to all sanitizers tests that were failing on Linux (independently of whether the issue was lacking sanitizer support on Linux or as here Obj-C support missing). | |
| lldb/packages/Python/lldbsuite/test/dotest.py | ||
|---|---|---|
| 839 | Thanks, will fix it in place. | |
nit: we do from lldbsuite.test import lldbplatformutil in the surrounding code, so that seems more consistent.