This is an archive of the discontinued LLVM Phabricator instance.

Fix LLDB ARM build error on ubuntu precise with gcc4.7
ClosedPublic

Authored by omjavaid on Apr 19 2015, 3:58 PM.

Reviewers

vharron
tberghammer

Commits

Summary

LLDB Arm build fails on ubuntu precise with gcc4.7 with following error

error: case value evaluates to 4283649346, which cannot be narrowed to type 'int' [-Wc++11-narrowing]

The compiler fails to store #define CIFS_MAGIC_NUMBER 0xFF534D42 into a singed int value as in statfs.h the type is being declared as int .

To work around this issue we type cast type value into an unsigned int.

This is safe as type is dependent on the actual 4 byte value stored in it rather than the sign.

omjavaid retitled this revision from to Fix LLDB ARM build error on ubuntu precise with gcc4.7.

omjavaid updated this object.

omjavaid edited the test plan for this revision. (Show Details)

omjavaid added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Apr 20 2015, 2:29 AM

Please add the review link to the commit message with the following syntax (see examples in the git log):

Differential revision: http://reviews.llvm.org/D9100

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Host/

posix/

2 lines

Context not available.
	{	{
	#ifdef __linux__	#ifdef __linux__
	#define CIFS_MAGIC_NUMBER 0xFF534D42	#define CIFS_MAGIC_NUMBER 0xFF534D42
	switch (info.f_type)	switch ((uint32_t)info.f_type)
	{	{
	case NFS_SUPER_MAGIC:	case NFS_SUPER_MAGIC:
	case SMB_SUPER_MAGIC:	case SMB_SUPER_MAGIC:
Context not available.