Use positive logic (i.e. llgs_platform/debugserver_platform) for
indicating which platforms use the particular server variant.
Deduplicate the lists — it is rather expected that none of the platforms
using LLGS would use debugserver.
Details
Diff Detail
Event Timeline
lldb/packages/Python/lldbsuite/test/dotest.py | ||
---|---|---|
951 | This is not entirely equivalent to the previous version -- it won't match "platforms" like "freebsd4.7". Fortunately, we already have some canonicalization code in lldbplatformutil.getPlatform(), so if you switch to that, it should be fine. | |
954 | I certainly hope so. I doubt anyone would port debugserver to another os, and I definitely would not want to carry another debugserver around. |
lldb/packages/Python/lldbsuite/test/dotest.py | ||
---|---|---|
951 | Good catch! However, this doesn't seem to work: Command Output (stderr): -- Traceback (most recent call last): File "/home/mgorny/llvm-project/llvm/tools/lldb/test/API/dotest.py", line 7, in <module> lldbsuite.test.run_suite() File "/usr/home/mgorny/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 855, in run_suite from lldbsuite.test import lldbplatformutil File "/usr/home/mgorny/llvm-project/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py", line 19, in <module> import lldb ModuleNotFoundError: No module named 'lldb' -- There is apparently some obscure problem behind the scenes and it seems above my pay grade. I'll just revert to the old code. | |
954 | Ok, I will remove the comment about adding more platforms then. |
Removed the part about adding new platforms without LLGS, and restored old conditions for matching platforms.
lldb/packages/Python/lldbsuite/test/dotest.py | ||
---|---|---|
951 | This is fiddly, because all of this happens very early, before everything is set up. |
This is not entirely equivalent to the previous version -- it won't match "platforms" like "freebsd4.7". Fortunately, we already have some canonicalization code in lldbplatformutil.getPlatform(), so if you switch to that, it should be fine.