[sanitizer] Get Android API from --target

[vitalybuka]

Summary

Depends on D90792.

[oontvoo]

compiler-rt/CMakeLists.txt

280

I thought this was causing cmake error

http://lab.llvm.org:8011/#/builders/99/builds/447

[vitalybuka]

Do you know why it was broken?
Is that because of undefined ANDROID_API_LEVEL?
if so if(ANDROID AND should be enough.

Is there any other reason to run CHECK_CXX_SOURCE_COMPILES? it's should be slower than REGEX MATCH.

[vitalybuka]

In D90793#2374680, @vitalybuka wrote:

Do you know why it was broken?
Is that because of undefined ANDROID_API_LEVEL?
if so if(ANDROID AND should be enough.

Nice, it's on our bot. I'll figure that out myself.

Is there any other reason to run CHECK_CXX_SOURCE_COMPILES? it's should be slower than REGEX MATCH.

This Q is still open.

[oontvoo]

In D90793#2374680, @vitalybuka wrote:

Do you know why it was broken?
Is that because of undefined ANDROID_API_LEVEL?
if so if(ANDROID AND should be enough.

Wouldn't it still become if (ANDROID AND <empty> GREATER_EQUAL 28), which is still malformed?
How about we just set ANDROID_API_LEVEL to -1 for the non-android case?

(Disclaimer: not an expert in cmake)

Is there any other reason to run CHECK_CXX_SOURCE_COMPILES? it's should be slower than REGEX MATCH.

No. I was just trying to avoid the cmake error.

[vitalybuka]

fix cmake error

compiler-rt/CMakeLists.txt

280

this works

[vitalybuka]

compiler-rt/CMakeLists.txt

280

True if the given string or variable’s value is a valid number and greater than or equal to that on the right.

undef is going to be empty string so it's not a number

compiler-rt/CMakeLists.txt

 
 construct_compiler_rt_default_triple()
 if ("${COMPILER_RT_DEFAULT_TARGET_TRIPLE}" MATCHES ".*hf$")
   if (${COMPILER_RT_DEFAULT_TARGET_ARCH} MATCHES "^arm")
     set(COMPILER_RT_DEFAULT_TARGET_ARCH "armhf")
     CHECK_SYMBOL_EXISTS (__thumb__ "" COMPILER_RT_ARM_THUMB)
   endif()
 endif()
-
-set(ANDROID_HAS_ELF_TLS 0)
 if ("${COMPILER_RT_DEFAULT_TARGET_TRIPLE}" MATCHES ".*android.*")
   set(ANDROID 1)
-  CHECK_CXX_SOURCE_COMPILES("
-int main() {
-#if __ANDROID_API__ >= 28
-    return 0;
-#else
-  #error NO_ELF_TLS
-  return 1;
-#endif
-}
-  " ANDROID_HAS_ELF_TLS)
   string(REGEX MATCH "-target(=| +)[^ ]+android([0-9]+)" ANDROID_API_LEVEL "${CMAKE_C_FLAGS}")
-  set(ANDROID_API_LEVEL ${CMAKE_MATCH_2}) 
+  set(ANDROID_API_LEVEL ${CMAKE_MATCH_2})
 endif()
 pythonize_bool(ANDROID)
 
 set(COMPILER_RT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 set(COMPILER_RT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
 
 pythonize_bool(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR)
 

 append_string_if(COMPILER_RT_HAS_STD_CXX14_FLAG -std=c++14 CMAKE_CXX_FLAGS)
 
 # Emulate C99 and C++11's __func__ for MSVC prior to 2013 CTP.
 if(NOT COMPILER_RT_HAS_FUNC_SYMBOL)
   add_definitions(-D__func__=__FUNCTION__)
 endif()
 
 # Provide some common commmandline flags for Sanitizer runtimes.
-if(ANDROID_HAS_ELF_TLS)
+if(ANDROID AND ${ANDROID_API_LEVEL} GREATER_EQUAL 28)
   list(APPEND SANITIZER_COMMON_CFLAGS -fno-emulated-tls)
   list(APPEND COMPILER_RT_TEST_COMPILER_CFLAGS -fno-emulated-tls)
 endif()
 if(NOT WIN32)
   append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC SANITIZER_COMMON_CFLAGS)
 endif()
 append_list_if(COMPILER_RT_HAS_FNO_BUILTIN_FLAG -fno-builtin SANITIZER_COMMON_CFLAGS)
 append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS)