This is an archive of the discontinued LLVM Phabricator instance.

Differential D90744

[llvm-exegesis][X86] Ignore a few unmeasurable opcodes.
ClosedPublic

Authored by courbet on Nov 4 2020, 1:47 AM.

Details

Reviewers
gchatelet
Commits
rGb16cbd8890a0: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes.

Diff Detail

Unit TestsFailed

TimeTest
380 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

courbet created this revision.Nov 4 2020, 1:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2020, 1:47 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
courbet requested review of this revision.Nov 4 2020, 1:47 AM
gchatelet accepted this revision.Nov 4 2020, 2:01 AM
This revision is now accepted and ready to land.Nov 4 2020, 2:01 AM
Harbormaster completed remote builds in B77520: Diff 302780.Nov 4 2020, 2:35 AM
This revision was landed with ongoing or failed builds.Feb 26 2021, 1:49 AM
Closed by commit rGb16cbd8890a0: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes. (authored by courbet). · Explain Why
This revision was automatically updated to reflect the committed changes.
courbet added a commit: rGb16cbd8890a0: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes..

Revision Contents

PathSize
llvm/
tools/
llvm-exegesis/
lib/
X86/
15 lines

Diff 302780

llvm/tools/llvm-exegesis/lib/X86/Target.cpp

Show First 20 Lines • Show All 189 Lines • ▼ Show 20 Lines
// the reason. nullptr indicates a valid opcode. // the reason. nullptr indicates a valid opcode.
static const char *isInvalidOpcode(const Instruction &Instr) { static const char *isInvalidOpcode(const Instruction &Instr) {
const auto OpcodeName = Instr.Name; const auto OpcodeName = Instr.Name;
if ((Instr.Description.TSFlags & X86II::FormMask) == X86II::Pseudo) if ((Instr.Description.TSFlags & X86II::FormMask) == X86II::Pseudo)
return "unsupported opcode: pseudo instruction"; return "unsupported opcode: pseudo instruction";
if (OpcodeName.startswith("POP") || OpcodeName.startswith("PUSH") || if (OpcodeName.startswith("POP") || OpcodeName.startswith("PUSH") ||
OpcodeName.startswith("ADJCALLSTACK") || OpcodeName.startswith("LEAVE")) OpcodeName.startswith("ADJCALLSTACK") || OpcodeName.startswith("LEAVE"))
return "unsupported opcode: Push/Pop/AdjCallStack/Leave"; return "unsupported opcode: Push/Pop/AdjCallStack/Leave";
switch (Instr.Description.Opcode) {
case X86::LFS16rm:
case X86::LFS32rm:
case X86::LFS64rm:
case X86::LGS16rm:
case X86::LGS32rm:
case X86::LGS64rm:
case X86::LSS16rm:
case X86::LSS32rm:
case X86::LSS64rm:
case X86::SYSENTER:
return "unsupported opcode";
default:
break;
}
if (const auto reason = isInvalidMemoryInstr(Instr)) if (const auto reason = isInvalidMemoryInstr(Instr))
return reason; return reason;
// We do not handle instructions with OPERAND_PCREL. // We do not handle instructions with OPERAND_PCREL.
for (const Operand &Op : Instr.Operands) for (const Operand &Op : Instr.Operands)
if (Op.isExplicit() && if (Op.isExplicit() &&
Op.getExplicitOperandInfo().OperandType == MCOI::OPERAND_PCREL) Op.getExplicitOperandInfo().OperandType == MCOI::OPERAND_PCREL)
return "unsupported opcode: PC relative operand"; return "unsupported opcode: PC relative operand";
// We do not handle second-form X87 instructions. We only handle first-form // We do not handle second-form X87 instructions. We only handle first-form
▲ Show 20 Lines • Show All 733 Lines • Show Last 20 Lines