This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [Plugins/FreeBSDRemote] Disable GetMemoryRegionInfo()
ClosedPublic

Authored by mgorny on Nov 2 2020, 2:56 PM.

Details

Summary

Disable GetMemoryRegionInfo() in order to unbreak expression parsing.
For some reason, the presence of non-stub function causes LLDB to fail
to detect system libraries correctly. Through being unable to find
mmap() and allocate memory, this leads to expression parser being
broken.

The issue is non-trivial and it is going to require more time debugging.
On the other hand, the downsides of missing the function are minimal
(2 failing tests), and the benefit of working expression parser
justifies disabling it temporarily. Furthermore, the old FreeBSD plugin
did not implement it anyway, so it allows us to switch to the new plugin
without major regressions.

The really curious part is that the respective code in the NetBSD plugin
yields very similar results, yet does not seem to break the expression
parser.

Diff Detail

Event Timeline

mgorny created this revision.Nov 2 2020, 2:56 PM
mgorny requested review of this revision.Nov 2 2020, 2:56 PM
krytarowski accepted this revision.Nov 2 2020, 3:19 PM
This revision is now accepted and ready to land.Nov 2 2020, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2020, 12:46 AM