This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Assume getrandom might not be supported by the kernel
ClosedPublic

Authored by zatrazz on Nov 2 2020, 9:51 AM.

Reviewers

Summary

It was added on kernel 3.17.

	Time	Test
	370 ms	windows > LLVM.CodeGen/AMDGPU::ds_read2.ll

zatrazz requested review of this revision.Nov 2 2020, 9:51 AM

The change makes sense to me and will fix ARM broken bots, I'd say that it can be accepted if there is no objection within a day

LGTM

This revision is now accepted and ready to land.Nov 5 2020, 2:51 AM

Path

Size

compiler-rt/

test/

sanitizer_common/

TestCases/

Posix/

3 lines

	// RUN: %clang -O2 %s -o %t && %run %t			// RUN: %clang -O2 %s -o %t && %run %t
	// UNSUPPORTED: android, netbsd, darwin, solaris			// UNSUPPORTED: android, netbsd, darwin, solaris
	//			//

	#include <sys/types.h>			#include <sys/types.h>
				#include <errno.h>

	#if !defined(__GLIBC_PREREQ)			#if !defined(__GLIBC_PREREQ)
	#define __GLIBC_PREREQ(a, b) 0			#define __GLIBC_PREREQ(a, b) 0
	#endif			#endif

	#if (defined(__linux__) && __GLIBC_PREREQ(2, 25)) \|\| defined(__FreeBSD__)			#if (defined(__linux__) && __GLIBC_PREREQ(2, 25)) \|\| defined(__FreeBSD__)
	#define HAS_GETRANDOM			#define HAS_GETRANDOM
	#endif			#endif

	#if defined(HAS_GETRANDOM)			#if defined(HAS_GETRANDOM)
	#include <sys/random.h>			#include <sys/random.h>
	#endif			#endif

	int main() {			int main() {
	char buf[16];			char buf[16];
	ssize_t n = 1;			ssize_t n = 1;
	#if defined(HAS_GETRANDOM)			#if defined(HAS_GETRANDOM)
	n = getrandom(buf, sizeof(buf), 0);			n = getrandom(buf, sizeof(buf), 0);
				if (n == -1 && errno == ENOSYS)
				n = 1;
	#endif			#endif
	return (int)(n <= 0);			return (int)(n <= 0);
	}			}