This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets
ClosedPublic

Authored by mstorsjo on Nov 1 2020, 12:59 PM.

Diff Detail

Event Timeline

mstorsjo created this revision.Nov 1 2020, 12:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2020, 12:59 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript
mstorsjo requested review of this revision.Nov 1 2020, 12:59 PM
rnk added inline comments.Nov 2 2020, 12:23 PM
compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp
15

Truly, MSVC is the odd duck: I would change the condition to !defined(_MSC_VER), it will work for clang and msvc.

compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp
15

Ditto, this could just be defined(_MSC_VER).

mstorsjo updated this revision to Diff 302374.Nov 2 2020, 12:40 PM

Just checking _MSC_VER instead of checking SANITIZER_WINDOWS && !__MINGW32__.

rnk accepted this revision.Nov 2 2020, 12:54 PM

lgtm

This revision is now accepted and ready to land.Nov 2 2020, 12:54 PM