This is an archive of the discontinued LLVM Phabricator instance.

[clang][NFC] Remove unused FileCheck prefix
ClosedPublic

Authored by keith on Oct 29 2020, 2:11 PM.

Download Raw Diff

Details

Reviewers

google-llvm-upstream-contributions
mtrofin

Commits

rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix

Summary

This is to enable --allow-unused-duplicates=false. This prefix appears
to be outdated and intentionally unused.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	410 ms	linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

keith created this revision.Oct 29 2020, 2:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2020, 2:11 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

keith requested review of this revision.Oct 29 2020, 2:11 PM

Harbormaster completed remote builds in B76980: Diff 301751.Oct 29 2020, 2:38 PM

lgtm

This revision is now accepted and ready to land.Oct 30 2020, 12:42 PM

In D90430#2365397, @google-llvm-upstream-contributions wrote:

lgtm

ugh, sorry, that's an alias I am auto-logged in on my personal account.

Still LGTM :)

This revision was landed with ongoing or failed builds.Oct 30 2020, 1:32 PM

Closed by commit rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix (authored by keith). · Explain Why

This revision was automatically updated to reflect the committed changes.

keith added a commit: rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix.

Revision Contents

Path

Size

clang/

test/

Driver/

debug-options.c

2 lines

Diff 301751

clang/test/Driver/debug-options.c

	Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Lines
	// RUN: %clang -### -c -ggdb0 %s 2>&1 \| FileCheck -check-prefix=G_NO %s			// RUN: %clang -### -c -ggdb0 %s 2>&1 \| FileCheck -check-prefix=G_NO %s
	// RUN: %clang -### -c -glldb -g0 %s 2>&1 \| FileCheck -check-prefix=G_NO %s			// RUN: %clang -### -c -glldb -g0 %s 2>&1 \| FileCheck -check-prefix=G_NO %s
	// RUN: %clang -### -c -glldb -g1 %s 2>&1 \			// RUN: %clang -### -c -glldb -g1 %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=GLTO_ONLY -check-prefix=G_LLDB %s			// RUN: \| FileCheck -check-prefix=GLTO_ONLY -check-prefix=G_LLDB %s
	//			//
	// PS4 defaults to sce; -ggdb0 changes tuning but turns off debug info,			// PS4 defaults to sce; -ggdb0 changes tuning but turns off debug info,
	// then -g turns it back on without affecting tuning.			// then -g turns it back on without affecting tuning.
	// RUN: %clang -### -c -ggdb0 -g -target x86_64-scei-ps4 %s 2>&1 \			// RUN: %clang -### -c -ggdb0 -g -target x86_64-scei-ps4 %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=G -check-prefix=G_GDB %s			// RUN: \| FileCheck -check-prefix=G_GDB %s
	//			//
	// RUN: %clang -### -c -g1 %s 2>&1 \			// RUN: %clang -### -c -g1 %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=GLTO_ONLY %s			// RUN: \| FileCheck -check-prefix=GLTO_ONLY %s
	// RUN: %clang -### -c -gmlt %s 2>&1 \			// RUN: %clang -### -c -gmlt %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=GLTO_ONLY %s			// RUN: \| FileCheck -check-prefix=GLTO_ONLY %s
	// RUN: %clang -### -c -gline-tables-only %s 2>&1 \			// RUN: %clang -### -c -gline-tables-only %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=GLTO_ONLY %s			// RUN: \| FileCheck -check-prefix=GLTO_ONLY %s
	// RUN: %clang -### -c -gline-tables-only %s -target x86_64-apple-darwin 2>&1 \			// RUN: %clang -### -c -gline-tables-only %s -target x86_64-apple-darwin 2>&1 \
	▲ Show 20 Lines • Show All 248 Lines • Show Last 20 Lines