This is an archive of the discontinued LLVM Phabricator instance.

Differential D90396

[VE] Change to use integrated assembly by defualt
ClosedPublic

Authored by kaz7 on Oct 29 2020, 7:27 AM.

Details

Reviewers
simoll
k-ishizaka
Commits
rGb5ac3721c8a4: [VE] Change to use integrated assembly by defualt
Summary

We've implemented integrated assembler. Now, we change to use
integrated assembler by default. Update a regression test also.

Diff Detail

Unit TestsFailed

TimeTest
350 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

kaz7 created this revision.Oct 29 2020, 7:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2020, 7:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kaz7 requested review of this revision.Oct 29 2020, 7:27 AM
simoll accepted this revision.Oct 29 2020, 7:42 AM

Great work! Thanks :)

This revision is now accepted and ready to land.Oct 29 2020, 7:42 AM
Harbormaster completed remote builds in B76911: Diff 301612.Oct 29 2020, 7:58 AM
This revision was landed with ongoing or failed builds.Oct 29 2020, 8:16 AM
Closed by commit rGb5ac3721c8a4: [VE] Change to use integrated assembly by defualt (authored by kaz7). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaz7 added a commit: rGb5ac3721c8a4: [VE] Change to use integrated assembly by defualt.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line
test/
Driver/
10 lines

Diff 301612

clang/lib/Driver/ToolChains/VEToolchain.h

Show All 20 Linespublic:
VEToolChain(const Driver &D, const llvm::Triple &Triple, VEToolChain(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args); const llvm::opt::ArgList &Args);
protected: protected:
Tool *buildAssembler() const override; Tool *buildAssembler() const override;
Tool *buildLinker() const override; Tool *buildLinker() const override;
public: public:
bool IsIntegratedAssemblerDefault() const override { return true; }
bool isPICDefault() const override; bool isPICDefault() const override;
bool isPIEDefault() const override; bool isPIEDefault() const override;
bool isPICDefaultForced() const override; bool isPICDefaultForced() const override;
bool SupportsProfiling() const override; bool SupportsProfiling() const override;
bool hasBlocksRuntime() const override; bool hasBlocksRuntime() const override;
void void
AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs, AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args) const override; llvm::opt::ArgStringList &CC1Args) const override;
Show All 30 Lines

clang/test/Driver/ve-toolchain.c

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
// RUN: %clang -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFEXCEPTION %s // RUN: %clang -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFEXCEPTION %s
// DEFEXCEPTION: clang{{.*}} "-cc1" // DEFEXCEPTION: clang{{.*}} "-cc1"
// DEFEXCEPTION: "-fsjlj-exceptions" // DEFEXCEPTION: "-fsjlj-exceptions"
///----------------------------------------------------------------------------- ///-----------------------------------------------------------------------------
/// Passing -fintegrated-as /// Passing -fintegrated-as
// RUN: %clang -### -target ve -x assembler %s 2>&1 | \ // RUN: %clang -### -target ve -x assembler %s 2>&1 | \
// RUN: FileCheck -check-prefix=NAS_LINK %s
// RUN: %clang -### -target ve -fintegrated-as -x assembler %s 2>&1 | \
// RUN: FileCheck -check-prefix=AS_LINK %s // RUN: FileCheck -check-prefix=AS_LINK %s
// RUN: %clang -### -target ve -fno-integrated-as -x assembler %s 2>&1 | \
// NAS_LINK: nas{{.*}} // RUN: FileCheck -check-prefix=NAS_LINK %s
// NAS_LINK: nld{{.*}}
// AS_LINK: clang{{.*}} "-cc1as" // AS_LINK: clang{{.*}} "-cc1as"
// AS_LINK: nld{{.*}} // AS_LINK: nld{{.*}}
// NAS_LINK: nas{{.*}}
// NAS_LINK: nld{{.*}}