Page MenuHomePhabricator

ARM: Update R_ARM_TARGET1 command line option names (remove prefix 'arm-')
ClosedPublic

Authored by lenykholodov on Apr 15 2015, 12:50 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

lenykholodov retitled this revision from to ARM: Update R_ARM_TARGET1 command line option names (remove prefix 'arm-').
lenykholodov updated this object.
lenykholodov edited the test plan for this revision. (Show Details)
lenykholodov added reviewers: atanasyan, ruiu.
lenykholodov set the repository for this revision to rL LLVM.
lenykholodov added a project: lld.
lenykholodov added a subscriber: Unknown Object (MLST).
atanasyan accepted this revision.Apr 15 2015, 1:12 PM
atanasyan edited edge metadata.

LGTM

lib/Driver/GnuLdDriver.cpp
549 ↗(On Diff #23795)

This does not relate to this patch but the else if statement violates the "else after a return" rule:
http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return

552 ↗(On Diff #23795)

We can handle both else if statements below in a uniform way:

else {
  for (const auto *arg : parsedArgs->filtered(OPT_grp_arm_targetopts)) {
    diag << "warning: ignoring unsupported ARM/ELF specific argument: "
         << arg->getSpelling() << "\n";
  }
}
This revision is now accepted and ready to land.Apr 15 2015, 1:12 PM
ruiu accepted this revision.Apr 15 2015, 1:12 PM
ruiu edited edge metadata.

LGTM

lenykholodov added inline comments.Apr 16 2015, 5:01 AM
lib/Driver/GnuLdDriver.cpp
552 ↗(On Diff #23795)

Thank you for this hint. I didn't know about such possibility.

This revision was automatically updated to reflect the committed changes.