Page MenuHomePhabricator

[ms] [llvm-ml] Add more documentation to unsupported options
AbandonedPublic

Authored by epastor on Oct 23 2020, 10:50 AM.

Details

Reviewers
None
Summary

Add documentation for the hidden unsupported ML.exe compatibility options.

Also consumes "/c" option without a warning, since that's our default behavior.

Diff Detail

Unit TestsFailed

TimeTest
420 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp
30 mslinux > LLVM.tools/llvm-ml::strings_errors.test
Script: -- : 'RUN: at line 1'; not llvm-ml -filetype=asm /mnt/disks/ssd0/agent/llvm-project/llvm/test/tools/llvm-ml/strings_errors.test 2>&1 | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/tools/llvm-ml/strings_errors.test --implicit-check-not=error:
50 mswindows > LLVM.tools/llvm-ml::strings_errors.test
Script: -- : 'RUN: at line 1'; not llvm-ml -filetype=asm C:\ws\w64\llvm-project\premerge-checks\llvm\test\tools\llvm-ml\strings_errors.test 2>&1 | c:\ws\w64\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w64\llvm-project\premerge-checks\llvm\test\tools\llvm-ml\strings_errors.test --implicit-check-not=error:

Event Timeline

epastor created this revision.Oct 23 2020, 10:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2020, 10:50 AM
epastor requested review of this revision.Oct 23 2020, 10:50 AM
epastor updated this revision to Diff 303175.Nov 5 2020, 10:33 AM

Rebase on HEAD

epastor updated this revision to Diff 303186.Nov 5 2020, 10:44 AM

Rebase on parent

I'd argue that we shouldn't have help texts for flags we don't support.

epastor updated this revision to Diff 307164.Nov 23 2020, 12:09 PM

Rebase on parent

I'd argue that we shouldn't have help texts for flags we don't support.

Fair enough; abandoned.

epastor abandoned this revision.Nov 23 2020, 12:10 PM