This is an archive of the discontinued LLVM Phabricator instance.

[PruneEH] Pin tests to legacy PM
ClosedPublic

Authored by aeubanks on Oct 22 2020, 10:34 PM.

Details

Summary

prune-eh will not be ported to the NPM. Instead, a combination of
function-attrs and simplifycfg should be used (as described in
https://reviews.llvm.org/D44415).

This pins most tests using -prune-eh to the legacy PM. Some of these
were testing legacy PM infra (mostly the CGPassManager). Some of these
can be tested in the NPM using function-attrs and simplifycfg.

One interesting case is simplenoreturntest.ll. function-attrs +
simplifycfg does not yet make a caller of a caller of a noreturn
function end with unreachable like prune-eh does. That can be added in
the future.

Diff Detail

Event Timeline

aeubanks created this revision.Oct 22 2020, 10:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2020, 10:34 PM
aeubanks requested review of this revision.Oct 22 2020, 10:34 PM
This revision is now accepted and ready to land.Oct 29 2020, 5:39 PM
This revision was landed with ongoing or failed builds.Oct 29 2020, 6:25 PM
This revision was automatically updated to reflect the committed changes.

FWIW, once we enable the Attributor, prune-eh is obsolete either way.