[nfc] [lldb] Fix harmless slicing of DWARFDIE

[jankratochvil]

Summary

Is return {...}; implicit ctor OK for LLDB? I have found only one line (return {sdk};) in rG5935227e11f5 using that syntax and I would normally use it everywhere.

[labath]

Is return {...}; implicit ctor OK for LLDB? I have found only one line (return {sdk};) in rG5935227e11f5 using that syntax and I would normally use it everywhere.

We don't have a policy on that. I personally wouldn't recommend using it literally _everywhere_ (this can get messy in very long function and particularly if you start nesting the {}s), but here it's perfectly fine.

lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h

public:
   virtual void BuildAddressRangeTable(DWARFDebugAranges *debug_aranges) = 0;
 
   lldb::ByteOrder GetByteOrder() const;
 
   const DWARFDebugAranges &GetFunctionAranges();
 
   void SetBaseAddress(dw_addr_t base_addr);
 
-  DWARFBaseDIE GetUnitDIEOnly() { return DWARFDIE(this, GetUnitDIEPtrOnly()); }
+  DWARFBaseDIE GetUnitDIEOnly() { return {this, GetUnitDIEPtrOnly()}; }
 
   DWARFDIE DIE() { return DWARFDIE(this, DIEPtr()); }
 
   DWARFDIE GetDIE(dw_offset_t die_offset);
 
   DWARFUnit &GetNonSkeletonUnit();
 
   static uint8_t GetAddressByteSize(const DWARFUnit *cu);