Page MenuHomePhabricator

Add a LLDB buildbot builder for FreeBSD
AcceptedPublic

Authored by tigergao99 on Oct 20 2020, 1:50 PM.

Details

Reviewers
gkistanova
Group Reviewers
Restricted Project
Summary

Add a LLDB buildbot builder for FreeBSD.
Build workers credentials still need be added.

Diff Detail

Event Timeline

tigergao99 created this revision.Oct 20 2020, 1:50 PM
tigergao99 requested review of this revision.Oct 20 2020, 1:50 PM
tigergao99 edited the summary of this revision. (Show Details)

Updated after rebasing to upstream master

W00t! FreeBSD FTW!

Any updates on this differential?

The change looks good to me but @gkistanova usually handles buildbot operations, so I don't want to approve before she has time to look at it.

gkistanova accepted this revision.Mon, Nov 2, 9:52 PM

LGTM with a nitpick.

buildbot/osuosl/master/config/builders.py
996

Do you need the OS version to be a part of the name?
Are you going to run bots for different versions simultaneously? If not, then maybe more generic names are better, since versions will change over time.

This revision is now accepted and ready to land.Mon, Nov 2, 9:52 PM
tigergao99 updated this revision to Diff 302571.Tue, Nov 3, 6:51 AM
tigergao99 added inline comments.
buildbot/osuosl/master/config/builders.py
996

Makes sense to me. I will use a generic name instead.

The patch is ready to be committed now

Thanks for changing the names,
Please feel free to commit.