Page MenuHomePhabricator

Driver: Add integer sanitizers to trapping group automatically.
ClosedPublic

Authored by pcc on Oct 19 2020, 11:23 PM.

Details

Summary

In D86000 we added a new sanitizer to the integer group
without adding it to the trapping group. This broke usage of
-fsanitize=integer -fsanitize-trap=integer or -fsanitize=integer
-fsanitize-minimal-runtime.

I think we can reasonably expect any new integer sanitizers to be
compatible with trapping and the minimal runtime, so add them to the
trapping group automatically.

Also add a test to ensure that any future additions of sanitizers
to the integer group will most likely result in test failures which
would lead to updates to the minimal runtime if necessary. For this
particular sanitizer no updates are required because it uses the
existing shift_out_of_bounds callback function.

Diff Detail

Event Timeline

pcc created this revision.Oct 19 2020, 11:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 11:23 PM
pcc requested review of this revision.Oct 19 2020, 11:23 PM
pirama added a subscriber: pirama.Oct 20 2020, 12:15 PM
eugenis accepted this revision.Oct 20 2020, 1:42 PM

LGTM

This revision is now accepted and ready to land.Oct 20 2020, 1:42 PM
This revision was landed with ongoing or failed builds.Oct 20 2020, 1:46 PM
This revision was automatically updated to reflect the committed changes.