This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py
ClosedPublic

Authored by aganea on Oct 19 2020, 10:38 AM.

Details

Summary

Improve rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77 as suggested by @ted :

"if lldbplatformutil.getPlatform() != "windows": will check if the lldb platform is windows; this won’t be true if running embedded lldb tests on windows. Since we want to see if the host is windows, better to say if sys.platform != "win32":"

Diff Detail

Event Timeline

aganea created this revision.Oct 19 2020, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 10:38 AM
aganea requested review of this revision.Oct 19 2020, 10:38 AM
This revision is now accepted and ready to land.Oct 19 2020, 11:18 AM