This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Exclude domain socket tests on windows, like freebsd/darwin
ClosedPublic

Authored by mstorsjo on Oct 19 2020, 2:36 AM.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 19 2020, 2:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 2:36 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Herald added a subscriber: krytarowski. · View Herald Transcript
mstorsjo requested review of this revision.Oct 19 2020, 2:36 AM
ldionne accepted this revision.Oct 19 2020, 5:51 AM
ldionne added a subscriber: ldionne.

LGTM with the comment rewording applied.

libcxx/test/support/filesystem_test_helper.h
159

// Some platforms don't support socket files [...]

This revision is now accepted and ready to land.Oct 19 2020, 5:51 AM