This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Enable cmake policy CMP0077 for option()
ClosedPublic

Authored by kastiglione on Oct 16 2020, 11:08 PM.

Details

Summary

In lldb, explicitly set the "option() honors normal variables" CMake policy. This applies for
standalone lldb builds and matches what llvm, clang, etc do. This prevents potentially unwanted
clearing of variables like LLVM_ENABLE_WARNINGS, and also prevents unnecessary build warnings.

See: https://cmake.org/cmake/help/latest/policy/CMP0077.html

Diff Detail

Event Timeline

kastiglione created this revision.Oct 16 2020, 11:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 11:08 PM
kastiglione requested review of this revision.Oct 16 2020, 11:08 PM
JDevlieghere accepted this revision.Oct 16 2020, 11:17 PM
This revision is now accepted and ready to land.Oct 16 2020, 11:17 PM
This revision was automatically updated to reflect the committed changes.