This is an archive of the discontinued LLVM Phabricator instance.

Differential D89614

[lldb] Enable cmake policy CMP0077 for option()
ClosedPublic

Authored by kastiglione on Oct 16 2020, 11:08 PM.

Details

Reviewers
JDevlieghere
Commits
rGae4fe1984f0e: [lldb] Enable cmake policy CMP0077 for option()
Summary

In lldb, explicitly set the "option() honors normal variables" CMake policy. This applies for
standalone lldb builds and matches what llvm, clang, etc do. This prevents potentially unwanted
clearing of variables like LLVM_ENABLE_WARNINGS, and also prevents unnecessary build warnings.

See: https://cmake.org/cmake/help/latest/policy/CMP0077.html

Diff Detail

Event Timeline

kastiglione created this revision.Oct 16 2020, 11:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 11:08 PM
Herald added subscribers: lldb-commits, mgorny. · View Herald Transcript
kastiglione requested review of this revision.Oct 16 2020, 11:08 PM
JDevlieghere accepted this revision.Oct 16 2020, 11:17 PM
This revision is now accepted and ready to land.Oct 16 2020, 11:17 PM
Harbormaster completed remote builds in B75409: Diff 298805.Oct 16 2020, 11:40 PM
Closed by commit rGae4fe1984f0e: [lldb] Enable cmake policy CMP0077 for option() (authored by kastiglione). · Explain WhyOct 17 2020, 12:16 AM
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rGae4fe1984f0e: [lldb] Enable cmake policy CMP0077 for option().

Revision Contents

PathSize
lldb/
4 lines

Diff 298805

lldb/CMakeLists.txt

cmake_minimum_required(VERSION 3.13.4) cmake_minimum_required(VERSION 3.13.4)
if(POLICY CMP0075) if(POLICY CMP0075)
cmake_policy(SET CMP0075 NEW) cmake_policy(SET CMP0075 NEW)
endif() endif()
if(POLICY CMP0077)
cmake_policy(SET CMP0077 NEW)
endif()
# Add path for custom modules. # Add path for custom modules.
set(CMAKE_MODULE_PATH set(CMAKE_MODULE_PATH
${CMAKE_MODULE_PATH} ${CMAKE_MODULE_PATH}
"${CMAKE_CURRENT_SOURCE_DIR}/cmake" "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
) )
# If we are not building as part of LLVM, build LLDB as a standalone project, # If we are not building as part of LLVM, build LLDB as a standalone project,
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines