This is an archive of the discontinued LLVM Phabricator instance.

Differential D89589

[lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()
ClosedPublic

Authored by kastiglione on Oct 16 2020, 1:09 PM.

Details

Reviewers
jingham
Commits
rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()
Summary

Implement GetName for ObjCExceptionThrowFrameRecognizer. Otherwise, frame recognizer list shows "(internal)" for the name.

Diff Detail

Event Timeline

kastiglione created this revision.Oct 16 2020, 1:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 1:09 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
kastiglione requested review of this revision.Oct 16 2020, 1:09 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptOct 16 2020, 1:09 PM
jingham accepted this revision.Oct 16 2020, 1:22 PM

LGTM

This revision is now accepted and ready to land.Oct 16 2020, 1:22 PM
This revision was landed with ongoing or failed builds.Oct 16 2020, 2:24 PM
Closed by commit rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName() (authored by kastiglione). · Explain Why
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName().
Harbormaster completed remote builds in B75364: Diff 298732.Oct 16 2020, 2:36 PM
shafik added a subscriber: shafik.Oct 16 2020, 3:59 PM

test?

Revision Contents

PathSize
lldb/
source/
Plugins/
LanguageRuntime/
ObjC/
AppleObjCRuntime/
3 lines

Diff 298754

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

Show First 20 Lines • Show All 2,703 Lines • ▼ Show 20 Lines
}; };
class ObjCExceptionThrowFrameRecognizer : public StackFrameRecognizer { class ObjCExceptionThrowFrameRecognizer : public StackFrameRecognizer {
lldb::RecognizedStackFrameSP lldb::RecognizedStackFrameSP
RecognizeFrame(lldb::StackFrameSP frame) override { RecognizeFrame(lldb::StackFrameSP frame) override {
return lldb::RecognizedStackFrameSP( return lldb::RecognizedStackFrameSP(
new ObjCExceptionRecognizedStackFrame(frame)); new ObjCExceptionRecognizedStackFrame(frame));
}; };
std::string GetName() override {
return "ObjC Exception Throw StackFrame Recognizer";
}
}; };
static void RegisterObjCExceptionRecognizer(Process *process) { static void RegisterObjCExceptionRecognizer(Process *process) {
FileSpec module; FileSpec module;
ConstString function; ConstString function;
std::tie(module, function) = AppleObjCRuntime::GetExceptionThrowLocation(); std::tie(module, function) = AppleObjCRuntime::GetExceptionThrowLocation();
std::vector<ConstString> symbols = {function}; std::vector<ConstString> symbols = {function};
process->GetTarget().GetFrameRecognizerManager().AddRecognizer( process->GetTarget().GetFrameRecognizerManager().AddRecognizer(
StackFrameRecognizerSP(new ObjCExceptionThrowFrameRecognizer()), StackFrameRecognizerSP(new ObjCExceptionThrowFrameRecognizer()),
module.GetFilename(), symbols, module.GetFilename(), symbols,
/*first_instruction_only*/ true); /*first_instruction_only*/ true);
} }