[libcxx] [test] Split the file_time_type synopsis test

[mstorsjo]

Summary

Split the resolution check to a separate test, which is marked as unsupported on windows.

On windows (both with MS STL and libstdc++), the file time has 100 ns resolution; the standard doesn't mandate a specific resolution.

[ldionne]

libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/file_time_type.pass.cpp

35

I would rather you mark the whole test as // UNSUPPORTED on Windows. Or split this part of the test into another test, and mark that as unsupported.

I'm trying to get rid of platform specific #ifs in the test suite when possible. It gives a better overview of what is and isn't supported when running the test suite on various platforms.

[mstorsjo]

Split the test into two, instead of adding ifdefs.

[ldionne]

LGTM with the suggested change.

libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/file_time_type_resolution.pass.cpp

24 ↗

(On Diff #298718)

Can you rename to file_time_type_resolution.compile.pass.cpp and just use:

using namespace fs;
using Dur = file_time_type::duration;
using Period = Dur::period;
ASSERT_SAME_TYPE(Period, std::nano);

No need for main or test_time_point_resolution_and_range().

libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/file_time_type.pass.cpp

void test_trivial_clock() {
   using Clock = file_time_type::clock;
   ASSERT_NOEXCEPT(Clock::now());
   ASSERT_SAME_TYPE(decltype(Clock::now()), file_time_type);
   ASSERT_SAME_TYPE(Clock::time_point, file_time_type);
   volatile auto* odr_use = &Clock::is_steady;
   ((void)odr_use);
 }
 
-void test_time_point_resolution_and_range() {
-  using namespace fs;
-  using Dur = file_time_type::duration;
-  using Period = Dur::period;
-  ASSERT_SAME_TYPE(Period, std::nano);
-}
-
 int main(int, char**) {
   test_trivial_clock();
-  test_time_point_resolution_and_range();
 
   return 0;
 }

libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/file_time_type_resolution.compile.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, windows
+
+// MS STL and libstdc++ use the native windows file timestamp resolution,
+// with 100 ns resolution.
+
+// <filesystem>
+
+// typedef TrivialClock file_time_type;
+
+#include "filesystem_include.h"
+#include <chrono>
+#include <type_traits>
+
+#include "test_macros.h"
+
+using namespace fs;
+using Dur = file_time_type::duration;
+using Period = Dur::period;
+ASSERT_SAME_TYPE(Period, std::nano);