[lldb] Replace TestAbortExitCode with a debugserver specific test

[teemperor]

Summary

When I added TestAbortExitCode I actually planned this to be a generic test for the
exit code functionality on POSIX systems. However due to all the different test setups we
can have I don't think this worked out. Right now the test had to be made so permissive
that it pretty much can't fail.

Just to summarize, we would need to support the following situations:

1. ToT debugserver (on macOS)
2. lldb-server (on other platforms)
3. Any old debugserver version when using the system debugserver (on macOS)

This patch is removing TestAbortExitCode and adds a ToT debugserver specific test
that checks the patch that motivated the whole exit code testing. There is already
an exit-code test for lldb-server from what I can see and 3) is pretty much untestable
as we don't know anything about the system debugserver.

[kastiglione]

Thanks

lldb/test/API/macosx/debugserver-exit-code/TestDebugServerExitCode.py

12

is this required even if it's not explicitly used?

[teemperor]

lldb/test/API/macosx/debugserver-exit-code/TestDebugServerExitCode.py

12

If you mean whether this test will work without this line: Nope, TestBase will complain as it uses that to compute the actual path to the current test file.

Whether we could potentially get rid of the mydir = ... boilerplate: Potentially. I believe it was only really necessary due to the way the test suite was originally designed (where one could run dotest.py as the test driver for multiple *.py test files). Jonas probably knows more about that.

lldb/test/API/macosx/debugserver-exit-code/Makefile

+C_SOURCES := main.c
+
+include Makefile.rules

lldb/test/API/macosx/debugserver-exit-code/TestDebugServerExitCode.py

+"""
+Tests the exit code/description coming from the debugserver.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+class TestCase(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+    @no_debug_info_test
+    @skipUnlessDarwin
+    @skipIfOutOfTreeDebugserver
+    def test_abort(self):
+        self.build()
+        target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+        process = target.LaunchSimple(None, None, None)
+        # Continue until process is terminated.
+        process.Continue()
+        # Test for the abort signal code.
+        self.assertEqual(process.GetExitStatus(), 6)
+        # Test for the exit code description.
+        self.assertEqual(process.GetExitDescription(),
+                         "Terminated due to signal 6")

lldb/test/Shell/Process/TestAbortExitCode.test

-UNSUPPORTED: system-windows
-
-RUN: %clang_host %p/Inputs/abort.c -o %t
-RUN: %lldb %t -o run -o continue | FileCheck %s
-
-CHECK: {{status = 6 \(0x00000006\)|status = 0 \(0x00000000\) Terminated due to signal 6}}