This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [COFF] Fix a condition that was missed in 7f0e6c31c255
ClosedPublic

Authored by mstorsjo on Oct 7 2020, 2:16 PM.

Details

Summary

This should fix cases when e.g. auto import is enabled without mingw mode in total being enabled, in combination with LTO.

Not sure if it's worth adding a testcase for this, as it's mostly a benign consistency issue leftover from that commit.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 7 2020, 2:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 2:16 PM
Herald added a subscriber: dexonsmith. · View Herald Transcript
mstorsjo requested review of this revision.Oct 7 2020, 2:16 PM
rnk accepted this revision.Oct 13 2020, 12:31 PM

lgtm

This revision is now accepted and ready to land.Oct 13 2020, 12:31 PM
This revision was landed with ongoing or failed builds.Oct 15 2020, 8:34 AM
This revision was automatically updated to reflect the committed changes.