This is an archive of the discontinued LLVM Phabricator instance.

[lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation
ClosedPublic

Authored by teemperor on Oct 7 2020, 1:46 AM.

Details

Summary

We are still implementing our own logic for this that looks for a VCS file in the place where it
was before the monorepo migration. This removes this logic and just uses the CMake function
that LLVM/Clang are using.

Diff Detail

Event Timeline

teemperor created this revision.Oct 7 2020, 1:46 AM
teemperor requested review of this revision.Oct 7 2020, 1:46 AM

See clang/lib/Basic/CMakeLists.txt for the respective Clang code.

teemperor edited reviewers, added: kastiglione; removed: che666.Oct 7 2020, 2:00 AM
kastiglione accepted this revision.Oct 7 2020, 7:44 AM
This revision is now accepted and ready to land.Oct 7 2020, 7:44 AM
JDevlieghere accepted this revision.Oct 7 2020, 12:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 8:15 AM