This is an archive of the discontinued LLVM Phabricator instance.

Implement MUL, MUH, MULU and MUHU instructions
ClosedPublic

Authored by zoran.jovanovic on Apr 8 2015, 6:49 AM.

Diff Detail

Event Timeline

dsanders accepted this revision.Apr 15 2015, 2:24 AM
dsanders edited edge metadata.

LGTM except for a small issue in the muhu and possibly muh instructions. Once muhu is corrected and muh has been confirmed correct you can commit.

lib/Target/Mips/MicroMips32r6InstrInfo.td
25

I believe this is correct, but the encoding diagram only has 9-bits specified for this 10-bit field. Presumably is a leading zero is missing. I've asked the relevant people to confirm and correct the documentation.

27

I make it 0xd8.

This revision is now accepted and ready to land.Apr 15 2015, 2:24 AM
dsanders added inline comments.Apr 16 2015, 1:38 AM
lib/Target/Mips/MicroMips32r6InstrInfo.td
25

I've had confirmation that it's actually a trailing zero that's missing so I believe this should be 0x58

This revision was automatically updated to reflect the committed changes.