This is an archive of the discontinued LLVM Phabricator instance.

Paths

[lldb][NFC] remove unused local variable uuid
AbandonedPublic

Authored by zequanwu on Oct 5 2020, 9:59 PM.

Reviewers

amccarth
labath

zequanwu requested review of this revision.Oct 5 2020, 9:59 PM

This variable is definitely used. The uuid reference points into the module_spec object, which is then appended to the specs array, and returned.

This revision now requires changes to proceed.Oct 6 2020, 5:05 AM

sorry, I didn't notice that.

Path

Size

lldb/

source/

Plugins/

ObjectFile/

PECOFF/

3 lines

Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines	size_t ObjectFilePECOFF::GetModuleSpecifications(
}		}

auto *COFFObj = llvm::dyn_cast<llvm::object::COFFObjectFile>(binary->get());		auto *COFFObj = llvm::dyn_cast<llvm::object::COFFObjectFile>(binary->get());
if (!COFFObj)		if (!COFFObj)
return initial_count;		return initial_count;

ModuleSpec module_spec(file);		ModuleSpec module_spec(file);
ArchSpec &spec = module_spec.GetArchitecture();		ArchSpec &spec = module_spec.GetArchitecture();
lldb_private::UUID &uuid = module_spec.GetUUID();
if (!uuid.IsValid())
uuid = GetCoffUUID(*COFFObj);

switch (COFFObj->getMachine()) {		switch (COFFObj->getMachine()) {
case MachineAmd64:		case MachineAmd64:
spec.SetTriple("x86_64-pc-windows");		spec.SetTriple("x86_64-pc-windows");
specs.Append(module_spec);		specs.Append(module_spec);
break;		break;
case MachineX86:		case MachineX86:
spec.SetTriple("i386-pc-windows");		spec.SetTriple("i386-pc-windows");
▲ Show 20 Lines • Show All 1,041 Lines • Show Last 20 Lines