This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][dsl] Fix mutable default argument warning
ClosedPublic

Authored by arichardson on Oct 5 2020, 3:21 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGe426ae2bd5e0: [libcxx][dsl] Fix mutable default argument warning
Summary

This is flagged by PyCharm and can cause subtle bugs. While changing this
also re-sort the imports and add missing ones.

Diff Detail

Event Timeline

arichardson created this revision.Oct 5 2020, 3:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2020, 3:21 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
arichardson requested review of this revision.Oct 5 2020, 3:21 AM
ldionne accepted this revision.Oct 5 2020, 2:05 PM

Thanks! You have commit access, right?

This revision is now accepted and ready to land.Oct 5 2020, 2:05 PM

Yes, will commit shortly. Thanks for reviewing!

This revision was landed with ongoing or failed builds.Oct 5 2020, 3:23 PM
This revision was automatically updated to reflect the committed changes.