This is an archive of the discontinued LLVM Phabricator instance.

Differential D88694

[CMake][Fuchsia] Don't set WIN32 API, rely on autodetection
ClosedPublic

Authored by phosek on Oct 1 2020, 12:23 PM.

Details

Reviewers
leonardchan
Commits
rGde47e7122f69: [CMake][Fuchsia] Don't set WIN32 API, rely on autodetection
Summary

We prefer autodetection here to avoid persisting this configuration
in the generated __config header which is shared across targets.

Diff Detail

Event Timeline

phosek created this revision.Oct 1 2020, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2020, 12:23 PM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
phosek requested review of this revision.Oct 1 2020, 12:23 PM
leonardchan accepted this revision.Oct 1 2020, 12:30 PM
This revision is now accepted and ready to land.Oct 1 2020, 12:30 PM
Harbormaster completed remote builds in B73701: Diff 295648.Oct 1 2020, 12:34 PM
This revision was landed with ongoing or failed builds.Oct 1 2020, 12:36 PM
Closed by commit rGde47e7122f69: [CMake][Fuchsia] Don't set WIN32 API, rely on autodetection (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rGde47e7122f69: [CMake][Fuchsia] Don't set WIN32 API, rely on autodetection.

Revision Contents

PathSize
clang/
cmake/
caches/
1 line

Diff 295649

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Linesif(WIN32)
list(APPEND BUILTIN_TARGETS "${target}") list(APPEND BUILTIN_TARGETS "${target}")
set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "") set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "")
set(BUILTINS_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") set(BUILTINS_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
list(APPEND RUNTIME_TARGETS "${target}") list(APPEND RUNTIME_TARGETS "${target}")
set(RUNTIMES_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "") set(RUNTIMES_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "")
set(RUNTIMES_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") set(RUNTIMES_${target}_CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
set(RUNTIMES_${target}_LIBCXX_ABI_VERSION 2 CACHE STRING "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(RUNTIMES_${target}_LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "") set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "")
endif() endif()
foreach(target aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unknown-linux-gnu;x86_64-unknown-linux-gnu) foreach(target aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unknown-linux-gnu;x86_64-unknown-linux-gnu)
▲ Show 20 Lines • Show All 178 Lines • Show Last 20 Lines