[AST] do not error on APFloat invalidOp in default mode

[spatel]

Summary

If FP exceptions are ignored, we should not error out of compilation just because APFloat indicated an exception.
This is required as a preliminary step for D88238 which changes APFloat behavior for signaling NaN convert() to set the opInvalidOp exception status.

Currently, there is no way to trigger this error because convert() never sets opInvalidOp. FP binops that set opInvalidOp also create a NaN, so the path to checkFloatingPointResult() is blocked by a different diagnostic:

// [expr.pre]p4:
//   If during the evaluation of an expression, the result is not
//   mathematically defined [...], the behavior is undefined.
// FIXME: C++ rules require us to not conform to IEEE 754 here.
if (LHS.isNaN()) {
  Info.CCEDiag(E, diag::note_constexpr_float_arithmetic) << LHS.isNaN();
  return Info.noteUndefinedBehavior();
}
return checkFloatingPointResult(Info, E, St);

[rjmccall]

LGTM.

clang/lib/AST/ExprConstant.cpp

static bool checkFloatingPointResult(EvalInfo &Info, const Expr *E,
   if ((St & APFloat::opInexact) &&
       FPO.getRoundingMode() == llvm::RoundingMode::Dynamic) {
     // Inexact result means that it depends on rounding mode. If the requested
     // mode is dynamic, the evaluation cannot be made in compile time.
     Info.FFDiag(E, diag::note_constexpr_dynamic_rounding);
     return false;
   }
 
-  if (St & APFloat::opStatus::opInvalidOp) {
+  if ((St & APFloat::opStatus::opInvalidOp) &&
+      FPO.getFPExceptionMode() != LangOptions::FPE_Ignore) {
     // There is no usefully definable result.
     Info.FFDiag(E);
     return false;
   }
 
   // FIXME: if:
   // - evaluation triggered other FP exception, and
   // - exception mode is not "ignore", and