Page MenuHomePhabricator

[clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR
Needs ReviewPublic

Authored by loladiro on Sep 30 2020, 7:20 PM.

Details

Reviewers
tstellar
Summary

Otherwise clang installs all of its tools into bin/ while
LLVM installs its tools into (LLVM_TOOLS_INSTALL_DIR).
I could swear this used to work (and in fact the julia build system
assumes it), but I can't pin down a specific commit that would
have broken this, and julia has been relying on pre-compiled binaries
for a while now (that don't use this setting), so it may have been
broken for quite a while.

Diff Detail

Event Timeline

loladiro created this revision.Sep 30 2020, 7:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2020, 7:20 PM
loladiro requested review of this revision.Sep 30 2020, 7:20 PM
loladiro added a subscriber: Restricted Project.Sep 30 2020, 7:21 PM

Well, I've tested it and it doesn't seem to break anything for us (Gentoo) but I don't really understand why you'd have a different install dir for LLVM and Clang.

Well, I've tested it and it doesn't seem to break anything for us (Gentoo) but I don't really understand why you'd have a different install dir for LLVM and Clang.

We (Julia) ship LLVM as a dependency and put all the LLVM binaries into a separate tools folder so that folks can just add /bin to their path and don't pick up our custom LLVM.