This is an archive of the discontinued LLVM Phabricator instance.

Differential D88077

[SyntaxTree] Add tests for the assignment of the `canModify` tag.
ClosedPublic

Authored by eduucaldas on Sep 22 2020, 2:13 AM.

Details

Reviewers
gribozavr2
Commits
rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of the `canModify` tag.

Diff Detail

Event Timeline

eduucaldas created this revision.Sep 22 2020, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 2:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Sep 22 2020, 2:13 AM
Harbormaster completed remote builds in B72487: Diff 293382.Sep 22 2020, 2:48 AM
eduucaldas updated this revision to Diff 293389.Sep 22 2020, 2:49 AM

Add FIXME for MIN(X, Y)

eduucaldas added a reviewer: gribozavr2.Sep 22 2020, 2:50 AM
eduucaldas added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
3858–3927

This is the same as ModifiableNodes I just changed the order, to follow a sequence of complexity

eduucaldas added a comment.Sep 22 2020, 2:57 AM

Looking for feedback, specially on the names I used.
Also if you have ideas of interesting tests they will be gladly accepted :)

Harbormaster completed remote builds in B72490: Diff 293389.Sep 22 2020, 3:21 AM
gribozavr2 accepted this revision.Sep 22 2020, 6:00 AM
This revision is now accepted and ready to land.Sep 22 2020, 6:00 AM
Closed by commit rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of the `canModify` tag. (authored by eduucaldas). · Explain WhySep 22 2020, 6:17 AM
This revision was automatically updated to reflect the committed changes.
eduucaldas added a commit: rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of the `canModify` tag..

Revision Contents

PathSize
clang/
unittests/
Tooling/
Syntax/
200 lines

Diff 293389

clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

Show First 20 Lines • Show All 3,849 Lines • ▼ Show 20 Lines`-LinkageSpecificationDeclaration
| |-'int' | |-'int'
| |-SimpleDeclarator Declarator | |-SimpleDeclarator Declarator
| | `-'c' | | `-'c'
| `-';' | `-';'
`-'}' `-'}'
)txt")); )txt"));
} }
TEST_P(BuildSyntaxTreeTest, NonModifiableNodes) { TEST_P(BuildSyntaxTreeTest, Macro_ObjectLike_Leaf) {
// Some nodes are non-modifiable, they are marked with 'I:'. // All nodes can be mutated.
EXPECT_TRUE(treeDumpEqual(
R"cpp(
#define OPEN {
#define CLOSE }
void test() {
OPEN
1;
CLOSE
OPEN
2;
}
}
)cpp",
R"txt(
TranslationUnit Detached
`-SimpleDeclaration
|-'void'
|-SimpleDeclarator Declarator
| |-'test'
| `-ParametersAndQualifiers
| |-'(' OpenParen
| `-')' CloseParen
`-CompoundStatement
|-'{' OpenParen
|-CompoundStatement Statement
| |-'{' OpenParen
| |-ExpressionStatement Statement
| | |-IntegerLiteralExpression Expression
| | | `-'1' LiteralToken
| | `-';'
| `-'}' CloseParen
|-CompoundStatement Statement
| |-'{' OpenParen
| |-ExpressionStatement Statement
| | |-IntegerLiteralExpression Expression
| | | `-'2' LiteralToken
| | `-';'
| `-'}' CloseParen
`-'}' CloseParen
)txt"));
}
TEST_P(BuildSyntaxTreeTest, Macro_ObjectLike_MatchTree) {
// Some nodes are unmodifiable, they are marked with 'unmodifiable'.
EXPECT_TRUE(treeDumpEqual(
R"cpp(
#define BRACES {}
void test() BRACES
)cpp",
R"txt(
TranslationUnit Detached
`-SimpleDeclaration
|-'void'
|-SimpleDeclarator Declarator
| |-'test'
| `-ParametersAndQualifiers
| |-'(' OpenParen
| `-')' CloseParen
`-CompoundStatement
|-'{' OpenParen unmodifiable
`-'}' CloseParen unmodifiable
)txt"));
}
TEST_P(BuildSyntaxTreeTest, Macro_ObjectLike_MismatchTree) {
eduucaldasAuthorUnsubmitted
Done
ReplyInline Actions

This is the same as ModifiableNodes I just changed the order, to follow a sequence of complexity

eduucaldas: This is the same as `ModifiableNodes` I just changed the order, to follow a sequence of…
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqual(
R"cpp( R"cpp(
#define HALF_IF if (1+ #define HALF_IF if (1+
#define HALF_IF_2 1) {} #define HALF_IF_2 1) {}
void test() { void test() {
HALF_IF HALF_IF_2 else {} HALF_IF HALF_IF_2 else {}
})cpp", })cpp",
R"txt( R"txt(
Show All 23 Lines `-CompoundStatement
| |-'else' ElseKeyword | |-'else' ElseKeyword
| `-CompoundStatement ElseStatement | `-CompoundStatement ElseStatement
| |-'{' OpenParen | |-'{' OpenParen
| `-'}' CloseParen | `-'}' CloseParen
`-'}' CloseParen `-'}' CloseParen
)txt")); )txt"));
} }
TEST_P(BuildSyntaxTreeTest, ModifiableNodes) { TEST_P(BuildSyntaxTreeTest, Macro_FunctionLike_ModifiableArguments) {
// All nodes can be mutated. // FIXME: Note that the substitutions for `X` and `Y` are marked modifiable.
// However we cannot change `X` freely. Indeed if we change its substitution
// in the condition we should also change it the then-branch.
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqual(
R"cpp( R"cpp(
#define OPEN { #define MIN(X,Y) X < Y ? X : Y
#define CLOSE }
void test() { void test() {
OPEN MIN(1,2);
1;
CLOSE
OPEN
2;
}
} }
)cpp", )cpp",
R"txt( R"txt(
TranslationUnit Detached TranslationUnit Detached
`-SimpleDeclaration `-SimpleDeclaration
|-'void' |-'void'
|-SimpleDeclarator Declarator |-SimpleDeclarator Declarator
| |-'test' | |-'test'
| `-ParametersAndQualifiers | `-ParametersAndQualifiers
| |-'(' OpenParen | |-'(' OpenParen
| `-')' CloseParen | `-')' CloseParen
`-CompoundStatement `-CompoundStatement
|-'{' OpenParen |-'{' OpenParen
|-CompoundStatement Statement |-ExpressionStatement Statement
| |-'{' OpenParen | |-UnknownExpression Expression
| |-ExpressionStatement Statement | | |-BinaryOperatorExpression unmodifiable
| | |-IntegerLiteralExpression Expression | | | |-IntegerLiteralExpression LeftHandSide
| | | | `-'1' LiteralToken
| | | |-'<' OperatorToken unmodifiable
| | | `-IntegerLiteralExpression RightHandSide
| | | `-'2' LiteralToken
| | |-'?' unmodifiable
| | |-IntegerLiteralExpression
| | | `-'1' LiteralToken | | | `-'1' LiteralToken
| | `-';' | | |-':' unmodifiable
| `-'}' CloseParen | | `-IntegerLiteralExpression
|-CompoundStatement Statement | | `-'2' LiteralToken
| `-';'
`-'}' CloseParen
)txt"));
}
TEST_P(BuildSyntaxTreeTest, Macro_FunctionLike_MismatchTree) {
EXPECT_TRUE(treeDumpEqual(
R"cpp(
#define HALF_IF(X) if (X &&
#define HALF_IF_2(Y) Y) {}
void test() {
HALF_IF(1) HALF_IF_2(0) else {}
})cpp",
R"txt(
TranslationUnit Detached
`-SimpleDeclaration
|-'void'
|-SimpleDeclarator Declarator
| |-'test'
| `-ParametersAndQualifiers
| |-'(' OpenParen
| `-')' CloseParen
`-CompoundStatement
|-'{' OpenParen
|-IfStatement Statement
| |-'if' IntroducerKeyword unmodifiable
| |-'(' unmodifiable
| |-BinaryOperatorExpression unmodifiable
| | |-IntegerLiteralExpression LeftHandSide
| | | `-'1' LiteralToken
| | |-'&&' OperatorToken unmodifiable
| | `-IntegerLiteralExpression RightHandSide
| | `-'0' LiteralToken
| |-')' unmodifiable
| |-CompoundStatement ThenStatement unmodifiable
| | |-'{' OpenParen unmodifiable
| | `-'}' CloseParen unmodifiable
| |-'else' ElseKeyword
| `-CompoundStatement ElseStatement
| |-'{' OpenParen | |-'{' OpenParen
| |-ExpressionStatement Statement
| | |-IntegerLiteralExpression Expression
| | | `-'2' LiteralToken
| | `-';'
| `-'}' CloseParen | `-'}' CloseParen
`-'}' CloseParen `-'}' CloseParen
)txt")); )txt"));
} }
TEST_P(BuildSyntaxTreeTest, Macro_FunctionLike_Variadic) {
EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp(
#define CALL(F_NAME, ...) F_NAME(__VA_ARGS__)
void f(int);
void g(int, int);
void test() [[{
CALL(f, 0);
CALL(g, 0, 1);
}]]
)cpp",
{R"txt(
CompoundStatement
|-'{' OpenParen
|-ExpressionStatement Statement
| |-CallExpression Expression
| | |-IdExpression Callee
| | | `-UnqualifiedId UnqualifiedId
| | | `-'f'
| | |-'(' OpenParen unmodifiable
| | |-CallArguments Arguments
| | | `-IntegerLiteralExpression ListElement
| | | `-'0' LiteralToken
| | `-')' CloseParen unmodifiable
| `-';'
|-ExpressionStatement Statement
| |-CallExpression Expression
| | |-IdExpression Callee
| | | `-UnqualifiedId UnqualifiedId
| | | `-'g'
| | |-'(' OpenParen unmodifiable
| | |-CallArguments Arguments
| | | |-IntegerLiteralExpression ListElement
| | | | `-'0' LiteralToken
| | | |-',' ListDelimiter
| | | `-IntegerLiteralExpression ListElement
| | | `-'1' LiteralToken
| | `-')' CloseParen unmodifiable
| `-';'
`-'}' CloseParen
)txt"}));
}
TEST_P(BuildSyntaxTreeTest, InitDeclarator_Equal) { TEST_P(BuildSyntaxTreeTest, InitDeclarator_Equal) {
if (!GetParam().isCXX()) { if (!GetParam().isCXX()) {
return; return;
} }
EXPECT_TRUE(treeDumpEqualOnAnnotations( EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp( R"cpp(
struct S { S(int);}; struct S { S(int);};
void test() { void test() {
▲ Show 20 Lines • Show All 1,536 Lines • Show Last 20 Lines