This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Add tests for the assignment of the `canModify` tag.
ClosedPublic

Authored by eduucaldas on Sep 22 2020, 2:13 AM.

Diff Detail

Event Timeline

eduucaldas created this revision.Sep 22 2020, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 2:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Sep 22 2020, 2:13 AM

Add FIXME for MIN(X, Y)

eduucaldas added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
3858–3927

This is the same as ModifiableNodes I just changed the order, to follow a sequence of complexity

Looking for feedback, specially on the names I used.
Also if you have ideas of interesting tests they will be gladly accepted :)

gribozavr2 accepted this revision.Sep 22 2020, 6:00 AM
This revision is now accepted and ready to land.Sep 22 2020, 6:00 AM