This is an archive of the discontinued LLVM Phabricator instance.

[ELF][test] Delete large temporary files and make some temporary files smaller with two text segments
ClosedPublic

Authored by MaskRay on Sep 21 2020, 11:10 AM.

Details

Summary

Large files are cumbersome on some filesystems and can more easily trigger ENOSPC.

Some tests use two text sections with output section addresses to test branch ranges.
Use two text segments to prevent LLD from filling the gap and unnecessarily increasing the output size.

Diff Detail

Event Timeline

MaskRay created this revision.Sep 21 2020, 11:10 AM
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay requested review of this revision.Sep 21 2020, 11:10 AM
psmith accepted this revision.Sep 21 2020, 11:27 AM

Looks good to me. Thanks for cleaning this up, it will be of great help to 32-bit bots.

lld/test/ELF/aarch64-cortex-a53-843419-thunk-range.s
2–6

The other test has

rm -rf %t && split-file %s %t

Just thought I'd mention in case this wasn't deliberate.

This revision is now accepted and ready to land.Sep 21 2020, 11:27 AM
MaskRay updated this revision to Diff 293221.Sep 21 2020, 11:37 AM

Delete temporarily files larger than 100MiB early.

MaskRay retitled this revision from [ELF][test] Make some tests' temporary files smaller to [ELF][test] Delete large temporary files and make some temporary files smaller with two text segments.Sep 21 2020, 11:38 AM
MaskRay edited the summary of this revision. (Show Details)