[NewPM] Pin tests with -debug-pass to legacy PM

[aeubanks]

Summary

-debug-pass is a legacy PM only option.

Some tests checks that the pass returned that it made a change,
which is not relevant to the NPM, since passes return PreservedAnalyses.

Some tests check that passes are freed at the proper time, which is also
not relevant to the NPM.

[asbirlea]

For the NPM, there's -debug-pass-manager, so this would give you the corresponding coverage (with a different CHECK prefix). Some tests already have this.
Optional to add coverage for phi-values-usage.ll and alias-analysis-uses.ll, the others are already covered or are checking for Changed.

[aeubanks]

add NPM CHECK lines for phi-values-usage.ll
alias-analysis-uses.ll doesn't really seem to be testing anything that would make sense in the NPM

llvm/test/Analysis/BasicAA/phi-values-usage.ll

-; RUN: opt -debug-pass=Executions -phi-values -memcpyopt -instcombine -disable-output < %s 2>&1 | FileCheck %s -check-prefixes=CHECK,CHECK-MEMCPY
-; RUN: opt -debug-pass=Executions -memdep -instcombine -disable-output < %s 2>&1 | FileCheck %s -check-prefix=CHECK
+; RUN: opt -debug-pass=Executions -phi-values -memcpyopt -instcombine -disable-output < %s -enable-new-pm=0 2>&1 | FileCheck %s -check-prefixes=CHECK,CHECK-MEMCPY
+; RUN: opt -debug-pass=Executions -memdep -instcombine -disable-output < %s -enable-new-pm=0 2>&1 | FileCheck %s -check-prefix=CHECK
+; RUN: opt -debug-pass-manager -aa-pipeline=basic-aa -passes=memcpyopt,instcombine -disable-output < %s 2>&1 | FileCheck %s -check-prefixes=NPM,NPM-MEMCPY
 
 ; Check that phi values is not run when it's not already available, and that
 ; basicaa is not freed after a pass that preserves CFG, as it preserves CFG.
 
 ; CHECK: Executing Pass 'Phi Values Analysis'
 ; CHECK: Executing Pass 'Basic Alias Analysis (stateless AA impl)'
 ; CHECK: Executing Pass 'Memory Dependence Analysis'
 ; CHECK-MEMCPY: Executing Pass 'MemCpy Optimization'
 ; CHECK-MEMCPY-DAG: Freeing Pass 'MemCpy Optimization'
 ; CHECK-DAG: Freeing Pass 'Memory Dependence Analysis'
 ; CHECK-DAG: Freeing Pass 'Phi Values Analysis'
 ; CHECK-NOT: Executing Pass 'Phi Values Analysis'
 ; CHECK-NOT: Executing Pass 'Basic Alias Analysis (stateless AA impl)'
 ; CHECK: Executing Pass 'Combine redundant instructions'
 
+; NPM-DAG: Running analysis: PhiValuesAnalysis
+; NPM-DAG: Running analysis: BasicAA
+; NPM-DAG: Running analysis: MemoryDependenceAnalysis
+; NPM: Running pass: MemCpyOptPass
+; NPM-NOT: Invalidating analysis
+; NPM: Running pass: InstCombinePass
+
 target datalayout = "p:8:8-n8"
 
 declare void @otherfn([4 x i8]*)
 declare i32 @__gxx_personality_v0(...)
 declare void @llvm.lifetime.end.p0i8(i64, i8* nocapture)
 @c = external global i8*, align 1
 
 ; This function is one where if we didn't free basicaa after memcpyopt then the

llvm/test/Analysis/alias-analysis-uses.ll

-; RUN: opt -debug-pass=Executions -globals-aa -function-attrs -disable-output < %s 2>&1 | FileCheck %s
+; RUN: opt -debug-pass=Executions -globals-aa -function-attrs -disable-output < %s -enable-new-pm=0 2>&1 | FileCheck %s
 
 ; CHECK: Executing Pass 'Globals Alias Analysis'
 ; CHECK-NOT: Freeing Pass 'Globals Alias Analysis'
 ; CHECK: Executing Pass 'Deduce function attributes'
 ; CHECK: Freeing Pass 'Globals Alias Analysis'
 
 define void @test(i8* %p) {
   ret void
 }

llvm/test/Transforms/Coroutines/smoketest.ll

 ; Test that all coroutine passes run in the correct order at all optimization
 ; levels and -enable-coroutines adds coroutine passes to the pipeline.
 ;
 ; Legacy pass manager:
-; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O0 2>&1 | FileCheck %s
-; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O1 2>&1 | FileCheck %s
-; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O2 2>&1 | FileCheck %s
-; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O3 2>&1 | FileCheck %s
+; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O0 -enable-new-pm=0 2>&1 | FileCheck %s
+; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O1 -enable-new-pm=0 2>&1 | FileCheck %s
+; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O2 -enable-new-pm=0 2>&1 | FileCheck %s
+; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments -O3 -enable-new-pm=0 2>&1 | FileCheck %s
 ; RUN: opt < %s -disable-output -enable-coroutines -debug-pass=Arguments \
-; RUN:     -coro-early -coro-split -coro-elide -coro-cleanup 2>&1 | FileCheck %s
-; RUN: opt < %s -disable-output -debug-pass=Arguments 2>&1 \
+; RUN:     -coro-early -coro-split -coro-elide -coro-cleanup -enable-new-pm=0 2>&1 | FileCheck %s
+; RUN: opt < %s -disable-output -debug-pass=Arguments -enable-new-pm=0 2>&1 \
 ; RUN:     | FileCheck %s -check-prefix=NOCORO
 ; New pass manager:
 ; RUN: opt < %s -disable-output -passes='default<O0>' -enable-coroutines \
 ; RUN:     -debug-pass-manager 2>&1 | FileCheck %s -check-prefix=NEWPM
 ; RUN: opt < %s -disable-output -passes='default<O1>' -enable-coroutines \
 ; RUN:     -debug-pass-manager 2>&1 | FileCheck %s -check-prefix=NEWPM
 ; RUN: opt < %s -disable-output -passes='default<O2>' -enable-coroutines \
 ; RUN:     -debug-pass-manager 2>&1 | FileCheck %s -check-prefix=NEWPM

llvm/test/Transforms/GVN/preserve-analysis.ll

-; RUN: opt < %s -debug-pass=Structure -indvars -gvn -indvars 2>&1 -S | FileCheck --check-prefix=CHECK --check-prefix=IR %s
+; RUN: opt < %s -debug-pass=Structure -indvars -gvn -indvars -enable-new-pm=0 2>&1 -S | FileCheck --check-prefix=CHECK --check-prefix=IR %s
 ; RUN: opt < %s -debug-pass-manager -passes='require<domtree>,loop(loop-simplifycfg),gvn,loop(indvars)' 2>&1 -S | FileCheck --check-prefix=NEW-PM --check-prefix=IR %s
 
 ; Check CFG-only analysis are preserved by SCCP by running it between 2
 ; loop-vectorize runs.
 
 ; CHECK: Dominator Tree Construction
 ; CHECK: Natural Loop Information
 ; CHECK: Canonicalize natural loops

llvm/test/Transforms/InstCombine/early_constfold_changes_IR.ll

 ; This run line verifies that we get the expected constant fold.
 ; RUN: opt < %s -instcombine -S | FileCheck %s
 
 ; This run line verifies that InstructionCombiningPass::runOnFunction reports
 ; this as a modification of the IR.
-; RUN: opt < %s -instcombine -disable-output -debug-pass=Details 2>&1 | FileCheck %s --check-prefix=DETAILS
+; RUN: opt < %s -instcombine -disable-output -debug-pass=Details -enable-new-pm=0 2>&1 | FileCheck %s --check-prefix=DETAILS
 
 define i32 @foo(i32 %arg) #0 {
 ; CHECK-LABEL: @foo(
 ; CHECK-NEXT:  entry:
 ; CHECK-NEXT:    [[AND:%.*]] = and i32 [[ARG:%.*]], 7
 ; CHECK-NEXT:    ret i32 [[AND]]
 ;
 entry:
   %or = or i32 0, 7
   %and = and i32 %arg, %or
   ret i32 %and
 }
 
 ; DETAILS:  Made Modification 'Combine redundant instructions' on Function 'foo'

llvm/test/Transforms/InstSimplify/remove-dead-call.ll

 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -instsimplify -S -o /dev/null -debug-pass=Details 2>&1 | FileCheck --check-prefix DETAILS %s
+; RUN: opt < %s -instsimplify -S -o /dev/null -debug-pass=Details -enable-new-pm=0 2>&1 | FileCheck --check-prefix DETAILS %s
 ; RUN: opt < %s -instsimplify -S -o - | FileCheck %s
 
 ; Verify that InstSimplifyLegacyPass notifies the pass manager about changes
 ; being made (when a call is removed CGSCC must be updated).
 ;
 ; DETAILS: Made Modification 'Remove redundant instructions' on Function 'main'
 
 define internal void @func_1(i64* nocapture readnone %0) #0 {

llvm/test/Transforms/SCCP/preserve-analysis.ll

-; RUN: opt < %s -debug-pass=Structure -globals-aa -loop-vectorize -sccp -loop-vectorize -globals-aa 2>&1 -S | FileCheck %s
+; RUN: opt < %s -debug-pass=Structure -globals-aa -loop-vectorize -sccp -loop-vectorize -globals-aa -enable-new-pm=0 2>&1 -S | FileCheck %s
 ; RUN: opt < %s -debug-pass-manager -passes='loop-vectorize,sccp,loop-vectorize' 2>&1 -S | FileCheck --check-prefix=NEW-PM %s
 
 ; Check CFG-only analysis are preserved by SCCP by running it between 2
 ; loop-vectorize runs.
 
 ; CHECK: Globals Alias Analysis
 ; CHECK: Dominator Tree Construction
 ; CHECK: Natural Loop Information

llvm/test/Transforms/SimplifyCFG/two-entry-phi-fold-crash.ll

 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -S -simplifycfg -debug-pass=Details 2>&1 | FileCheck %s
+; RUN: opt < %s -S -simplifycfg -debug-pass=Details -enable-new-pm=0 2>&1 | FileCheck %s
 
 ;; Check the report from the pass manager, telling us whether simplifycfg
 ;; reported the "changed" status correctly:
 ; CHECK: Made Modification 'Simplify the CFG' on Function 'wibble'...
 
 declare i32 @blam(i8*, i32)
 
 define i32 @wibble(i8* %arg, i8** %arg1) {