When ELF header's e_machine == 0, we emit:
Machine: EM_NONE
We can avoid doing this, because yaml2obj sets the
e_machine field to EM_NONE by default.
Paths
| Differential D87829
[obj2yaml] - Don't emit EM_NONE. ClosedPublic Authored by grimar on Sep 17 2020, 5:46 AM.
Details
Summary When ELF header's e_machine == 0, we emit: Machine: EM_NONE We can avoid doing this, because yaml2obj sets the
Diff Detail Event TimelineThis revision is now accepted and ready to land.Sep 17 2020, 5:56 AM Closed by commit rG279943edf878: [obj2yaml] - Don't emit EM_NONE. (authored by grimar). · Explain WhySep 17 2020, 6:00 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 292473 llvm/test/tools/obj2yaml/ELF/call-graph-profile-section.yaml
llvm/test/tools/obj2yaml/ELF/duplicate-symbol-and-section-names.yaml
llvm/test/tools/obj2yaml/ELF/emachine.yaml
llvm/test/tools/obj2yaml/ELF/gnu-unique-symbols.yaml
llvm/test/tools/obj2yaml/ELF/implicit-sections-order.yaml
llvm/test/tools/obj2yaml/ELF/invalid-section-name.yaml
llvm/test/tools/obj2yaml/ELF/no-symtab.yaml
llvm/test/tools/obj2yaml/ELF/null-section.yaml
llvm/test/tools/obj2yaml/ELF/sht-symtab-shndx.yaml
llvm/test/tools/obj2yaml/ELF/stack-sizes.yaml
llvm/test/tools/obj2yaml/ELF/symbol-visibility.yaml
llvm/test/tools/obj2yaml/ELF/versym-section.yaml
llvm/tools/obj2yaml/elf2yaml.cpp
|