Page MenuHomePhabricator

[clang][codegen] Skip adding default function attributes on intrinsics.
ClosedPublic

Authored by hliao on Sep 16 2020, 7:26 AM.

Details

Summary
  • After loading builtin bitcode for linking, skip adding default function attributes on LLVM intrinsics as their attributes are well-defined and retrieved directly from internal definitions. Adding extra attributes on intrinsics results in inconsistent result when -save-temps is present. Also, that makes few optimizations conservative.

Diff Detail

Event Timeline

hliao created this revision.Sep 16 2020, 7:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2020, 7:26 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hliao requested review of this revision.Sep 16 2020, 7:26 AM
rjmccall accepted this revision.Sep 16 2020, 10:15 AM

Seems reasonable.

This revision is now accepted and ready to land.Sep 16 2020, 10:15 AM
tra accepted this revision.Sep 16 2020, 10:22 AM