This is an archive of the discontinued LLVM Phabricator instance.

Fix ThinLtoJit example compilation
ClosedPublic

Authored by jthemphill on Sep 10 2020, 3:08 PM.

Details

Reviewers
sgraenitz
lhames
Summary

It looks like c74900ca67241bf963b7a4cfa1fae8eadf6bb8cd changed IRLayer::emit() from accepting a MaterializationResponsibility to accepting a std::unique_ptr<MaterializationResponsibility>, which broke the compilation of the ThinLtoJIT example: https://reviews.llvm.org/harbormaster/build/91968/

This diff updates ThinLtoInstrumentationLayer.h and ThinLtoInstrumentationLayer.cpp to accept a std::unique_ptr<MaterializationResponsibility> instead.

Diff Detail

Event Timeline

jthemphill created this revision.Sep 10 2020, 3:08 PM
jthemphill requested review of this revision.Sep 10 2020, 3:08 PM
lhames accepted this revision.Sep 11 2020, 4:15 PM

Thanks Jeff! I've re-applied c74900ca6724 with a modified version of these fixes in 7dcd0042e8b.

This revision is now accepted and ready to land.Sep 11 2020, 4:15 PM
lhames closed this revision.Sep 11 2020, 4:15 PM