Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/unittests/Tooling/Syntax/MutationsTest.cpp | ||
---|---|---|
60–70 | I think it makes sense to split this into a separate file as well. If agreed this will be done in a separate patch, because it will also incur the creation of a Synthesis.h. Currently BuildTree.h is backed by Synthesis.cpp and BuildTree.cpp which I don't think makes a lot of sense |
clang/unittests/Tooling/Syntax/MutationsTest.cpp | ||
---|---|---|
48 | ||
56–57 | Could we split it into multiple test cases? TEST_P(MutationTest, RemoveStatement_BinaryExpression) { CheckTransformation( RemoveStatement, "void test() { [[100+100;]] test(); }", "void test() { test(); }"); } Also consider moving the std::function argument in CheckTransformation to the first position for readability of the call. | |
clang/unittests/Tooling/Syntax/SynthesisTest.cpp | ||
2–3 |