This is an archive of the discontinued LLVM Phabricator instance.

Differential D87324

[HIP] Add gfx1030 and gfx1031
ClosedPublic

Authored by yaxunl on Sep 8 2020, 1:07 PM.

Details

Reviewers
tra
ashi1
arsenm
Commits
rG041da0d828e3: [HIP] Add gfx1031 and gfx1030

Diff Detail

Event Timeline

yaxunl requested review of this revision.Sep 8 2020, 1:07 PM
yaxunl created this revision.
arsenm accepted this revision.Sep 8 2020, 1:11 PM
This revision is now accepted and ready to land.Sep 8 2020, 1:11 PM
Herald added a subscriber: wdng. · View Herald TranscriptSep 8 2020, 1:11 PM
ashi1 accepted this revision.Sep 8 2020, 1:16 PM

LGTM, looks like its already in clang/include/clang/Basic/Cuda.h and clang/lib/Basic/Targets/AMDGPU.cpp.

Closed by commit rG041da0d828e3: [HIP] Add gfx1031 and gfx1030 (authored by yaxunl). · Explain WhySep 8 2020, 1:39 PM
This revision was automatically updated to reflect the committed changes.
yaxunl added a commit: rG041da0d828e3: [HIP] Add gfx1031 and gfx1030.
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2020, 1:39 PM

Revision Contents

PathSize
clang/
lib/
Basic/
2 lines
test/
Driver/
10 lines

Diff 290570

clang/lib/Basic/Cuda.cpp

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 LinesCudaArchToStringMap arch_names[] = {
GFX(703), // kabini mullins GFX(703), // kabini mullins
GFX(704), // bonaire GFX(704), // bonaire
GFX(801), // carrizo GFX(801), // carrizo
GFX(802), // tonga,iceland GFX(802), // tonga,iceland
GFX(803), // fiji,polaris10 GFX(803), // fiji,polaris10
GFX(810), // stoney GFX(810), // stoney
GFX(900), // vega, instinct GFX(900), // vega, instinct
GFX(902), GFX(904), GFX(906), GFX(908), GFX(909), GFX(902), GFX(904), GFX(906), GFX(908), GFX(909),
GFX(1010), GFX(1011), GFX(1012), GFX(1010), GFX(1011), GFX(1012), GFX(1030), GFX(1031)
// clang-format on // clang-format on
}; };
#undef SM #undef SM
#undef SM2 #undef SM2
#undef GFX #undef GFX
const char *CudaArchToString(CudaArch A) { const char *CudaArchToString(CudaArch A) {
auto result = std::find_if( auto result = std::find_if(
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines

clang/test/Driver/hip-offload-arch.hip

  • This file was added.
// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target
// RUN: %clang -### -target x86_64-linux-gnu \
// RUN: --offload-arch=gfx1030 \
// RUN: --offload-arch=gfx1031 \
// RUN: -nogpuinc -nogpulib \
// RUN: %s 2>&1 | FileCheck %s
// CHECK: {{"[^"]*clang[^"]*".* "-target-cpu" "gfx1030"}}
// CHECK: {{"[^"]*clang[^"]*".* "-target-cpu" "gfx1031"}}