Page MenuHomePhabricator

[test] Use %t instead of %T to remove race conditions between config-file3.c and target-override.c
ClosedPublic

Authored by MaskRay on Sep 3 2020, 11:22 AM.

Details

Summary

Both tests operate on %T/testbin. If the two tests run concurrently,
one may fail.

This is likely the root cause of flaky failures reported by
https://lists.llvm.org/pipermail/llvm-dev/2020-September/144781.html

https://llvm.org/docs/CommandGuide/lit.html says:

%T parent directory of %t (not unique, deprecated, do not use)

Diff Detail

Event Timeline

MaskRay created this revision.Sep 3 2020, 11:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2020, 11:22 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay requested review of this revision.Sep 3 2020, 11:22 AM
dblaikie accepted this revision.Sep 3 2020, 12:04 PM

Looks good - thanks!

This revision is now accepted and ready to land.Sep 3 2020, 12:04 PM
This revision was landed with ongoing or failed builds.Sep 3 2020, 12:29 PM
This revision was automatically updated to reflect the committed changes.