This is an archive of the discontinued LLVM Phabricator instance.

Differential D86901

Change comments of openFileForWrite
AbandonedPublic

Authored by stephan.yichao.zhao on Aug 31 2020, 5:26 PM.

Details

Reviewers
sepavloff
MaskRay
Summary

The file it opens is not in read-write mode.

Diff Detail

Event Timeline

stephan.yichao.zhao created this revision.Aug 31 2020, 5:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2020, 5:26 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
stephan.yichao.zhao requested review of this revision.Aug 31 2020, 5:26 PM
stephan.yichao.zhao updated this revision to Diff 289052.Aug 31 2020, 5:33 PM

updated

stephan.yichao.zhao abandoned this revision.Aug 31 2020, 5:34 PM
Harbormaster completed remote builds in B70159: Diff 289051.Aug 31 2020, 6:08 PM
Harbormaster completed remote builds in B70160: Diff 289052.Aug 31 2020, 6:31 PM

Revision Contents

PathSize
llvm/
include/
llvm/
Support/
5 lines

Diff 289052

llvm/include/llvm/Support/FileSystem.h

Show First 20 Lines • Show All 1,007 Lines • ▼ Show 20 Lines
/// @param FileHandle File to read from. /// @param FileHandle File to read from.
/// @param Buf Buffer to read into. /// @param Buf Buffer to read into.
/// @param Offset Offset into the file at which the read should occur. /// @param Offset Offset into the file at which the read should occur.
/// @returns The number of bytes read, or error. /// @returns The number of bytes read, or error.
Expected<size_t> readNativeFileSlice(file_t FileHandle, Expected<size_t> readNativeFileSlice(file_t FileHandle,
MutableArrayRef<char> Buf, MutableArrayRef<char> Buf,
uint64_t Offset); uint64_t Offset);
/// @brief Opens the file with the given name in a write-only or read-write /// @brief Opens the file with the given name in a write-only mode, returning
/// mode, returning its open file descriptor. If the file does not exist, it /// its open file descriptor. If the file does not exist, it is created.
/// is created.
/// ///
/// The caller is responsible for closing the file descriptor once they are /// The caller is responsible for closing the file descriptor once they are
/// finished with it. /// finished with it.
/// ///
/// @param Name The path of the file to open, relative or absolute. /// @param Name The path of the file to open, relative or absolute.
/// @param ResultFD If the file could be opened successfully, its descriptor /// @param ResultFD If the file could be opened successfully, its descriptor
/// is stored in this location. Otherwise, this is set to -1. /// is stored in this location. Otherwise, this is set to -1.
/// @param Flags Additional flags used to determine whether the file should be /// @param Flags Additional flags used to determine whether the file should be
▲ Show 20 Lines • Show All 484 Lines • Show Last 20 Lines