Page MenuHomePhabricator

[lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest
ClosedPublic

Authored by JDevlieghere on Aug 28 2020, 2:20 PM.

Details

Summary

This patch removes the very confusing LLDB_LIB_DIR and LLDB_IMPLIB_DIR environment variables. They are confusing because LLDB_LIB_DIR would point to the bin subdirectory in the build root while LLDB_IMPLIB_DIR would point to the lib subdirectory. The reason far that was LLDB.framework, which gets build under bin. This patch replaces their uses with configuration.lldb_framework_path and configuration.lldb_libs_dir respectively.

Diff Detail

Event Timeline

JDevlieghere created this revision.Aug 28 2020, 2:20 PM
JDevlieghere requested review of this revision.Aug 28 2020, 2:20 PM
  • Fix LLDB.framework path
  • Don't try to guess the LLDB.framework location
rupprecht accepted this revision.Aug 28 2020, 3:07 PM
This revision is now accepted and ready to land.Aug 28 2020, 3:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2020, 3:46 PM