This is an archive of the discontinued LLVM Phabricator instance.

Differential D86492

[NewPM][test] Fix accelerate-vector-functions.ll under NPM
ClosedPublic

Authored by aeubanks on Aug 24 2020, 3:40 PM.

Details

Reviewers
spatel
Commits
rG78e4aeb7839e: [NewPM][test] Fix accelerate-vector-functions.ll under NPM
Summary

The legacy SLPVectorizer has a dependency on InjectTLIMappingsLegacy.
That cannot be expressed in the new PM since they are both normal
passes. Explicitly add -inject-tli-mappings as a pass.

Diff Detail

Event Timeline

aeubanks created this revision.Aug 24 2020, 3:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2020, 3:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks requested review of this revision.Aug 24 2020, 3:40 PM
Harbormaster completed remote builds in B69372: Diff 287515.Aug 24 2020, 4:22 PM
spatel accepted this revision.Aug 25 2020, 9:37 AM

LGTM. The other place you will hit this problem is in test/Transforms/LoopVectorize; there are a few test files there that specify -vector-library.

This revision is now accepted and ready to land.Aug 25 2020, 9:37 AM
Closed by commit rG78e4aeb7839e: [NewPM][test] Fix accelerate-vector-functions.ll under NPM (authored by aeubanks). · Explain WhyAug 25 2020, 10:50 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG78e4aeb7839e: [NewPM][test] Fix accelerate-vector-functions.ll under NPM.
aeubanks mentioned this in D86561: [test] Add -inject-tli-mapping to -loop-vectorize -vector-library tests.Aug 25 2020, 11:17 AM
aeubanks mentioned this in rGdf5576a85208: [test] Add -inject-tli-mapping to -loop-vectorize -vector-library tests.Aug 25 2020, 11:55 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
SLPVectorizer/
AArch64/
4 lines

Diff 287515

llvm/test/Transforms/SLPVectorizer/AArch64/accelerate-vector-functions.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -slp-vectorizer -vector-library=Accelerate -S %s | FileCheck %s ; RUN: opt -inject-tli-mappings -slp-vectorizer -vector-library=Accelerate -S %s | FileCheck %s
; RUN: opt -slp-vectorizer -S %s | FileCheck --check-prefix NOACCELERATE %s ; RUN: opt -inject-tli-mappings -slp-vectorizer -S %s | FileCheck --check-prefix NOACCELERATE %s
target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128" target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
target triple = "arm64-apple-ios14.0.0" target triple = "arm64-apple-ios14.0.0"
declare float @llvm.sin.f32(float) declare float @llvm.sin.f32(float)
; Accelerate provides sin() for <4 x float> ; Accelerate provides sin() for <4 x float>
define <4 x float> @int_sin_4x(<4 x float>* %a) { define <4 x float> @int_sin_4x(<4 x float>* %a) {
▲ Show 20 Lines • Show All 1,289 Lines • Show Last 20 Lines