This is an archive of the discontinued LLVM Phabricator instance.

Differential D86467

[SyntaxTree] Split `MemberPointer` tests with annotations
ClosedPublic

Authored by eduucaldas on Aug 24 2020, 9:14 AM.

Details

Reviewers
gribozavr2
Commits
rG61273f298f2c: [SyntaxTree] Split `MemberPointer` tests with annotations

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 24 2020, 9:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2020, 9:14 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Aug 24 2020, 9:14 AM
eduucaldas added a reviewer: gribozavr2.Aug 24 2020, 9:15 AM
Harbormaster completed remote builds in B69330: Diff 287415.Aug 24 2020, 9:50 AM
gribozavr2 accepted this revision.Aug 24 2020, 3:02 PM
This revision is now accepted and ready to land.Aug 24 2020, 3:02 PM
Closed by commit rG61273f298f2c: [SyntaxTree] Split `MemberPointer` tests with annotations (authored by eduucaldas). · Explain WhyAug 24 2020, 11:08 PM
This revision was automatically updated to reflect the committed changes.
eduucaldas added a commit: rG61273f298f2c: [SyntaxTree] Split `MemberPointer` tests with annotations.

Revision Contents

PathSize
clang/
unittests/
Tooling/
Syntax/
208 lines

Diff 287415

clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

Show First 20 Lines • Show All 4,053 Lines • ▼ Show 20 Lines`-SimpleDeclaration
`-; `-;
)txt")); )txt"));
} }
TEST_P(SyntaxTreeTest, MemberPointers) { TEST_P(SyntaxTreeTest, MemberPointers) {
if (!GetParam().isCXX()) { if (!GetParam().isCXX()) {
return; return;
} }
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp( R"cpp(
struct X {}; struct X {};
int X::* a; [[int X::* a;]]
const int X::* b; [[const int X::* b;]]
)cpp", )cpp",
{R"txt(
SimpleDeclaration
|-int
|-SimpleDeclarator
| |-MemberPointer
| | |-X
| | |-::
| | `-*
| `-a
`-;
)txt",
R"txt( R"txt(
*: TranslationUnit SimpleDeclaration
|-SimpleDeclaration
| |-struct
| |-X
| |-{
| |-}
| `-;
|-SimpleDeclaration
| |-int
| |-SimpleDeclarator
| | |-MemberPointer
| | | |-X
| | | |-::
| | | `-*
| | `-a
| `-;
`-SimpleDeclaration
|-const |-const
|-int |-int
|-SimpleDeclarator |-SimpleDeclarator
| |-MemberPointer | |-MemberPointer
| | |-X | | |-X
| | |-:: | | |-::
| | `-* | | `-*
| `-b | `-b
`-; `-;
)txt")); )txt"}));
} }
TEST_P(SyntaxTreeTest, MemberFunctionPointer) { TEST_P(SyntaxTreeTest, MemberFunctionPointer) {
if (!GetParam().isCXX()) { if (!GetParam().isCXX()) {
return; return;
} }
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp( R"cpp(
struct X { struct X {
struct Y {}; struct Y {};
}; };
void (X::*xp)(); [[void (X::*xp)();]]
void (X::**xpp)(const int*); [[void (X::**xpp)(const int*);]]
// FIXME: Generate the right syntax tree for this type, // FIXME: Generate the right syntax tree for this type,
// i.e. create a syntax node for the outer member pointer // i.e. create a syntax node for the outer member pointer
void (X::Y::*xyp)(const int*, char); [[void (X::Y::*xyp)(const int*, char);]]
)cpp", )cpp",
R"txt( {R"txt(
*: TranslationUnit SimpleDeclaration
|-SimpleDeclaration |-void
| |-struct |-SimpleDeclarator
| |-X | |-ParenDeclarator
| |-{
| |-SimpleDeclaration
| | |-struct
| | |-Y
| | |-{
| | |-}
| | `-;
| |-}
| `-;
|-SimpleDeclaration
| |-void
| |-SimpleDeclarator
| | |-ParenDeclarator
| | | |-(
| | | |-MemberPointer
| | | | |-X
| | | | |-::
| | | | `-*
| | | |-xp
| | | `-)
| | `-ParametersAndQualifiers
| | |-( | | |-(
| | |-MemberPointer
| | | |-X
| | | |-::
| | | `-*
| | |-xp
| | `-) | | `-)
| `-; | `-ParametersAndQualifiers
|-SimpleDeclaration | |-(
| |-void | `-)
| |-SimpleDeclarator `-;
| | |-ParenDeclarator )txt",
| | | |-( R"txt(
| | | |-MemberPointer SimpleDeclaration
| | | | |-X |-void
| | | | |-:: |-SimpleDeclarator
| | | | `-* | |-ParenDeclarator
| | | |-*
| | | |-xpp
| | | `-)
| | `-ParametersAndQualifiers
| | |-( | | |-(
| | |-SimpleDeclaration | | |-MemberPointer
| | | |-const | | | |-X
| | | |-int | | | |-::
| | | `-SimpleDeclarator
| | | `-* | | | `-*
| | |-*
| | |-xpp
| | `-) | | `-)
| `-; | `-ParametersAndQualifiers
`-SimpleDeclaration | |-(
| |-SimpleDeclaration
| | |-const
| | |-int
| | `-SimpleDeclarator
| | `-*
| `-)
`-;
)txt",
R"txt(
SimpleDeclaration
|-void |-void
|-SimpleDeclarator |-SimpleDeclarator
| |-ParenDeclarator | |-ParenDeclarator
| | |-( | | |-(
| | |-X | | |-X
| | |-:: | | |-::
| | |-MemberPointer | | |-MemberPointer
| | | |-Y | | | |-Y
| | | |-:: | | | |-::
| | | `-* | | | `-*
| | |-xyp | | |-xyp
| | `-) | | `-)
| `-ParametersAndQualifiers | `-ParametersAndQualifiers
| |-( | |-(
| |-SimpleDeclaration | |-SimpleDeclaration
| | |-const | | |-const
| | |-int | | |-int
| | `-SimpleDeclarator | | `-SimpleDeclarator
| | `-* | | `-*
| |-, | |-,
| |-SimpleDeclaration | |-SimpleDeclaration
| | `-char | | `-char
| `-) | `-)
`-; `-;
)txt")); )txt"}));
} }
TEST_P(SyntaxTreeTest, ComplexDeclarator) { TEST_P(SyntaxTreeTest, ComplexDeclarator) {
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqual(
R"cpp( R"cpp(
void x(char a, short (*b)(int)); void x(char a, short (*b)(int));
)cpp", )cpp",
R"txt( R"txt(
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines