This is an archive of the discontinued LLVM Phabricator instance.

Skip Alloca insts when finding insert point
AbandonedPublic

Authored by tdangeti on Aug 20 2020, 2:20 AM.

Reviewers

Summary

Verifier is complaining if the instructions are inserted b/w allocas.

tdangeti requested review of this revision.Aug 20 2020, 2:20 AM

Test?

Issue exists in older versions, could not find a relevant test case in the trunk.

Path

Size

llvm/

lib/

Transforms/

Scalar/

4 lines

Context not available.
	// still being dominated by the input positions.	// still being dominated by the input positions.
	BasicBlock::iterator IP = HoistInsertPosition(LowestIP, Inputs);	BasicBlock::iterator IP = HoistInsertPosition(LowestIP, Inputs);

	// Don't insert instructions before PHI nodes.	// Don't insert instructions before PHI nodes and Allocas.
	while (isa<PHINode>(IP)) ++IP;	while (isa<PHINode>(IP)) ++IP;

		while (isa<AllocaInst>(IP)) ++IP;
		Lint: Pre-merge checks Inline Actions clang-format: please reformat the code - while (isa<AllocaInst>(IP)) ++IP; + while (isa<AllocaInst>(IP)) + ++IP; Lint: Pre-merge checks: clang-format: please reformat the code ``` - while (isa<AllocaInst>(IP)) ++IP; + while…

	// Ignore landingpad instructions.	// Ignore landingpad instructions.
	while (IP->isEHPad()) ++IP;	while (IP->isEHPad()) ++IP;

Context not available.