Page MenuHomePhabricator

[lldb] Forcefully complete a type when adding typedefs
ClosedPublic

Authored by labath on Aug 19 2020, 6:59 AM.

Details

Summary

This is very similar to D85968, only more elusive to since we were not
adding the typedef type to the relevant DeclContext until D86140, which
meant that the DeclContext was populated (and the relevant assertion
hit) only after importing the type into the expression ast in a
particular way.

I haven't checked whether this situation can be hit in the gmodules
case, but my money is on "yes".

Diff Detail

Event Timeline

labath created this revision.Aug 19 2020, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2020, 6:59 AM
labath requested review of this revision.Aug 19 2020, 6:59 AM
This revision is now accepted and ready to land.Aug 19 2020, 10:15 PM
This revision was landed with ongoing or failed builds.Aug 20 2020, 6:24 AM
This revision was automatically updated to reflect the committed changes.